New issue
Advanced search Search tips

Issue 808464 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Simplify the Tricium plugin UI

Project Member Reported by mar...@chromium.org, Feb 2 2018

Issue description

It is important to reduce signals given to a CL author and the reviewers to only positive information. The fact that tricium had an internal failure (the task blew up, etc) should not be presented to the user, since this is not actionable. This should instead be reported to either:
- Tricium dev team
- Project owner (e.g. trooper)
- Analyzer owner (if it's an analyzer that failed)

In addition, it is important to not scale the information presented to gerrit with the number of analyzers running. At most, a single "Analyzing: N/M" yellow box then "Analyzed N" green box should be shown. In case of failure, if some analyzers ran, it should still be green. If no analyzer ran successfully, it should disappear.
 
Labels: -Pri-3 Pri-2
Owner: qyears...@chromium.org
Status: Assigned (was: Available)
The first change to make here might be to just show pending/running analyzers and analyzers with results. Changing to show only a single box will be more important at some point when there are more analyzers.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/052235216c40a0111d389e624ff296f5fc91f211

commit 052235216c40a0111d389e624ff296f5fc91f211
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Feb 08 22:48:31 2018

Don't show failed analyzers or functions.

This CL would change the Tricium progress UI to
set the style "display: none" for failure results.

Bug:  808464 
Change-Id: I10126755734f0bafba673897b624a7369037bd11
Reviewed-on: https://chromium-review.googlesource.com/909720
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/052235216c40a0111d389e624ff296f5fc91f211/src/main/resources/static/tricium-view.html

Cc: qyears...@chromium.org
Labels: -Pri-2 Milestone-Chromium Pri-3
Owner: ----
Status: Available (was: Assigned)
Summary: Tricium plugin: show only a single box, don't scale UI complexity with number of analyzers (was: Tricium: show only a single "running" box, do not show failure at all)
I'll change the focus of this bug to be to change the Gerrit plugin behavior:

 - If no analyzer ran successfully, the plugin UI should disappear.
 - If some analyzers are not finished, a "Analyzing: N/M" yellow box should be shown.
 - If all analyzers are finished, a green "Analyzed: N" box should be shown with the number of successful analyzers that ran. This shouldn't include any failed analyzers.

Optionally, there could be a "details" view mode that shows the status of all analyzers, but this wouldn't be shown by default.

This diverges from the buildbucket plugin UI, but it makes sense for the Tricium plugin, since the plugin UI is just FYI, not actionable.
Another slighly less minimal UI idea, inspired by Tricorder:

List the names of completed analyzers with results, and in-progress analyzers, but just don't list completed analyzers without results. Allow users to click to expand the Tricium view to see more details, including analyzers without results.

Comment 5 by estaab@chromium.org, Apr 26 2018

Cc: estaab@chromium.org
Labels: -Pri-3 Pri-2
Summary: Simplify the Tricium plugin UI (was: Tricium plugin: show only a single box, don't scale UI complexity with number of analyzers)
Components: Infra>Platform>Tricium
Components: -Infra>CodeAnalysis
Labels: -Tricium
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/4c3f39bd6494821cea107d9cccc132222ade723b

commit 4c3f39bd6494821cea107d9cccc132222ade723b
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Aug 02 17:44:25 2018

[tricium plugin] Remove the num-comments count

Reason: The count isn't as useful now since it shows
the total number of comments produced, which doesn't
match with the number of comments sent.

Bug:  808464 
Change-Id: Iaf629f5d176a57cf8aeeed27ae2d9a6918bd053b
Reviewed-on: https://chromium-review.googlesource.com/1160938
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/4c3f39bd6494821cea107d9cccc132222ade723b/src/main/resources/static/tricium-view.html

Status: Started (was: Available)
Proposed very simple change:

Just include "Tricium <run link>       ... more info / file a bug"

Including the patchset and last time updated might be unnecessary.

https://chromium-review.googlesource.com/c/infra/gerrit-plugins/tricium/+/1176431
tricium-view with no results.png
7.7 KB View Download
tricium-view with run.png
9.8 KB View Download
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a93547d76486eca28eb67bbe98a9b784d6e17bd2

commit a93547d76486eca28eb67bbe98a9b784d6e17bd2
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Mon Aug 20 16:57:37 2018

[tricium] Stop sending the run ID and URL with each comment

By not sending the robot run ID with each comment,
this should make it so that run ID links are not shown
in comments. This is OK if the run ID link is shown in
tricium-view.

Bug:  808464 ,  852889 
Change-Id: I2ddcc5ca747bde8e164f22a06d09df68300235aa
Reviewed-on: https://chromium-review.googlesource.com/1176443
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/a93547d76486eca28eb67bbe98a9b784d6e17bd2/go/src/infra/tricium/appengine/gerrit/gerrit_test.go
[modify] https://crrev.com/a93547d76486eca28eb67bbe98a9b784d6e17bd2/go/src/infra/tricium/appengine/gerrit/gerrit.go

Owner: qyears...@chromium.org
Status: Fixed (was: Started)
It is now simplified somewhat. We'll almost certainly want to change it later on, but that will be a separate task.

Sign in to add a comment