Simplify the Tricium plugin UI |
||||||||
Issue descriptionIt is important to reduce signals given to a CL author and the reviewers to only positive information. The fact that tricium had an internal failure (the task blew up, etc) should not be presented to the user, since this is not actionable. This should instead be reported to either: - Tricium dev team - Project owner (e.g. trooper) - Analyzer owner (if it's an analyzer that failed) In addition, it is important to not scale the information presented to gerrit with the number of analyzers running. At most, a single "Analyzing: N/M" yellow box then "Analyzed N" green box should be shown. In case of failure, if some analyzers ran, it should still be green. If no analyzer ran successfully, it should disappear.
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/052235216c40a0111d389e624ff296f5fc91f211 commit 052235216c40a0111d389e624ff296f5fc91f211 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Feb 08 22:48:31 2018 Don't show failed analyzers or functions. This CL would change the Tricium progress UI to set the style "display: none" for failure results. Bug: 808464 Change-Id: I10126755734f0bafba673897b624a7369037bd11 Reviewed-on: https://chromium-review.googlesource.com/909720 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/052235216c40a0111d389e624ff296f5fc91f211/src/main/resources/static/tricium-view.html
,
Mar 8 2018
I'll change the focus of this bug to be to change the Gerrit plugin behavior: - If no analyzer ran successfully, the plugin UI should disappear. - If some analyzers are not finished, a "Analyzing: N/M" yellow box should be shown. - If all analyzers are finished, a green "Analyzed: N" box should be shown with the number of successful analyzers that ran. This shouldn't include any failed analyzers. Optionally, there could be a "details" view mode that shows the status of all analyzers, but this wouldn't be shown by default. This diverges from the buildbucket plugin UI, but it makes sense for the Tricium plugin, since the plugin UI is just FYI, not actionable.
,
Apr 26 2018
Another slighly less minimal UI idea, inspired by Tricorder: List the names of completed analyzers with results, and in-progress analyzers, but just don't list completed analyzers without results. Allow users to click to expand the Tricium view to see more details, including analyzers without results.
,
Apr 26 2018
,
May 15 2018
,
Jun 15 2018
,
Jun 15 2018
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/4c3f39bd6494821cea107d9cccc132222ade723b commit 4c3f39bd6494821cea107d9cccc132222ade723b Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Aug 02 17:44:25 2018 [tricium plugin] Remove the num-comments count Reason: The count isn't as useful now since it shows the total number of comments produced, which doesn't match with the number of comments sent. Bug: 808464 Change-Id: Iaf629f5d176a57cf8aeeed27ae2d9a6918bd053b Reviewed-on: https://chromium-review.googlesource.com/1160938 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/4c3f39bd6494821cea107d9cccc132222ade723b/src/main/resources/static/tricium-view.html
,
Aug 15
Proposed very simple change: Just include "Tricium <run link> ... more info / file a bug" Including the patchset and last time updated might be unnecessary. https://chromium-review.googlesource.com/c/infra/gerrit-plugins/tricium/+/1176431
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/bd7a8827faf7750e5224b43c6fc75e3670370a05 commit bd7a8827faf7750e5224b43c6fc75e3670370a05 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Mon Aug 20 16:54:49 2018 [tricium] Simplify the tricium-view element This change removes some things: - All analyzer status and links - The messages patchset and update time And adds: - A run details link - A doc and bug-filing link Bug: 808464 , 852889 Change-Id: I15738428fb97f483b790aa8f23d8d7f7312ed614 Reviewed-on: https://chromium-review.googlesource.com/1176431 Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/src/main/resources/static/tricium-client.js [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/src/main/resources/static/tricium-view.js [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/test/tricium-client_test.html [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/test/tricium-view_test.html [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/test/example.html [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/src/main/resources/static/tricium-view.html
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a93547d76486eca28eb67bbe98a9b784d6e17bd2 commit a93547d76486eca28eb67bbe98a9b784d6e17bd2 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Mon Aug 20 16:57:37 2018 [tricium] Stop sending the run ID and URL with each comment By not sending the robot run ID with each comment, this should make it so that run ID links are not shown in comments. This is OK if the run ID link is shown in tricium-view. Bug: 808464 , 852889 Change-Id: I2ddcc5ca747bde8e164f22a06d09df68300235aa Reviewed-on: https://chromium-review.googlesource.com/1176443 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/a93547d76486eca28eb67bbe98a9b784d6e17bd2/go/src/infra/tricium/appengine/gerrit/gerrit_test.go [modify] https://crrev.com/a93547d76486eca28eb67bbe98a9b784d6e17bd2/go/src/infra/tricium/appengine/gerrit/gerrit.go
,
Oct 7
It is now simplified somewhat. We'll almost certainly want to change it later on, but that will be a separate task. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by qyears...@chromium.org
, Feb 8 2018Owner: qyears...@chromium.org
Status: Assigned (was: Available)