Add uma metrics to assess the size of the bookmarks JSON file |
|||
Issue descriptionBookmarks are currently persisted in a JSON file. Other data pieces are being considered to be stored in the same file. UMA metrics are needed to evaluate such approach. Such as the size of the JSON file, and time required to write it to desk.
,
Feb 5 2018
,
Feb 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3df2894f790e335c4947e47f19dc1526f34b96a4 commit 3df2894f790e335c4947e47f19dc1526f34b96a4 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Mon Feb 19 12:35:38 2018 Add uma metric for bookmarks JSON file size and time to write - Bookmarks JSON file size is instrumented when it's read (at startup). This represents the whole populations of bookmarks users. - Time to write is instrumented in ImportantFileWriter. Metrics in ImportantFileWriter are reported with suffix "BookmarkStorage" in our case. And accordingly, we can get accurate metrics values for time to write bookmarks file. This is instrumented at the write time. Bookmarks are written after an update in the bookmarks and hence the metric will be biased by bookmarks that are updated frequently. This is an intended behavior though in order to assess the impact of increasing the size of the JSON file. Bug: 808439 Change-Id: I7570727931e52b9f7dcdd5a48fd812faf2c4b6ab Reviewed-on: https://chromium-review.googlesource.com/901422 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#537634} [modify] https://crrev.com/3df2894f790e335c4947e47f19dc1526f34b96a4/base/files/important_file_writer.cc [modify] https://crrev.com/3df2894f790e335c4947e47f19dc1526f34b96a4/components/bookmarks/browser/bookmark_storage.cc [modify] https://crrev.com/3df2894f790e335c4947e47f19dc1526f34b96a4/tools/metrics/histograms/histograms.xml
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7178b8d068e65a6bb9deda20288cb071515e38c4 commit 7178b8d068e65a6bb9deda20288cb071515e38c4 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Tue Feb 27 20:34:42 2018 Bookmarks.FileSize histogram should be reported in kilobytes This CL fixes a bug in reporting the Bookmarks.FileSize metric. base::GetFileSize() return the file size in bytes while KBs are required. Additionally, UMA_HISTOGRAM_MEMORY_KB uses bucketing scheme as follows: The first bucket is for files smaller than 1000K(1MB) and the max bucket is for files larger than 500000KB (500MB) This CL changes the bucketing scheme to better represent small files (smaller than 1000KB) And adjusts the max to be 50MB which is more suitable for bookmarks files. 25 buckets should be enough for analysis. It should be OK to change the bucketing scheme because it didn't hit stable yet. Only canary reporting will be half broken. Bug: 808439 Change-Id: I098f5df128949a9e545dc59973def693ec540ec1 Reviewed-on: https://chromium-review.googlesource.com/931507 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#539536} [modify] https://crrev.com/7178b8d068e65a6bb9deda20288cb071515e38c4/components/bookmarks/browser/bookmark_storage.cc
,
Nov 16
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mamir@chromium.org
, Feb 5 2018