Same assert on the other asan bots, e.g.
https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan%28dll%29/324
https://ci.chromium.org/buildbot/chromium.clang/CrWinAsanCov/311


First red build:
https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/291

Reid, can you take a look if you're around? I'm heading out for the weekend.

Attaching repro source.

Stack with more symbols:

[1025/1025] CXX win_clang_nacl_win64/obj/chrome/installer/util/with_no_strings/lzma_util.obj
FAILED: win_clang_nacl_win64/obj/chrome/installer/util/with_no_strings/lzma_util.obj
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes  "-imsvcc:\src\chromium\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\include\10.0.15063.0\um" "-imsvcc:\src\chromium\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\include\10.0.15063.0\shared" "-imsvcc:\src\chromium\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\include\10.0.15063.0\winrt" "-imsvcc:\src\chromium\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\include\10.0.15063.0\ucrt" "-imsvcc:\src\chromium\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\vc\tools\msvc\14.11.25503\include" "-imsvcc:\src\chromium\src\third_party\depot_tools\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\vc\tools\msvc\14.11.25503\atlmfc\include" -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D"CR_CLANG_REVISION=\"324100\"" -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -DDEPRECATEDENUMERATOR(x)=[[deprecated(x)]] -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000000 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBP_EXTERN=extern -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=wchar_t -I../.. -Iwin_clang_nacl_win64/gen -I../../third_party/libwebp/src -I../../third_party/wtl/include -I../../third_party/protobuf/src -Iwin_clang_nacl_win64/gen/protoc_out -Iwin_clang_nacl_win64/gen/third_party/metrics_proto -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../third_party/crashpad/crashpad -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/lzma_sdk -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- -fmsc-version=1911 -m64 /W4 /WX /utf-8 /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 -Wno-unknown-pragmas -Wno-microsoft-cast -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-constant-compare -Wtautological-constant-out-of-range-compare /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /Z7 -fno-standalone-debug /MT -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare /FIbuild/precompile.h /wd4267 /Fpwin_clang_nacl_win64/obj/chrome/installer/util/with_no_strings_cc.pch /Yubuild/precompile.h /TP /wd4577 /GR- /c ../../chrome/installer/util/lzma_util.cc /Fowin_clang_nacl_win64/obj/chrome/installer/util/with_no_strings/lzma_util.obj /Fd"win_clang_nacl_win64/obj/chrome/installer/util/with_no_strings_cc.pdb"
Assertion failed: InsertionPt != Parent->end() && "Ill-formed basic block", file C:\src\chromium\src\third_party\llvm\lib\Transforms\Utils\Local.cpp, line 1377
Wrote crash dump file "c:\src\temp\clang-cl.exe-fa11ad.dmp"
LLVMSymbolizer: error reading file: PDB Error: Unable to load PDB.  Make sure the file exists and is readable.  Calling loadDataForExe

LLVMSymbolizer: error reading file: PDB Error: Unable to load PDB.  Make sure the file exists and is readable.  Calling loadDataForExe

#0 0x00007ff64de306c5 HandleAbort c:\src\chromium\src\third_party\llvm\lib\support\windows\signals.inc:411:0
#1 0x00007ff64f6eabf9 raise minkernel\crts\ucrt\src\appcrt\misc\signal.cpp:516:0
#2 0x00007ff64f6d8288 abort minkernel\crts\ucrt\src\appcrt\startup\abort.cpp:71:0
#3 0x00007ff64f6d79c2 common_assert_to_stderr<wchar_t> minkernel\crts\ucrt\src\appcrt\startup\assert.cpp:149:0
#4 0x00007ff64f6d7a5e _wassert minkernel\crts\ucrt\src\appcrt\startup\assert.cpp:404:0
#5 0x00007ff64dead3d1 llvm::insertDebugValuesForPHIs(class llvm::BasicBlock *,class llvm::SmallVectorImpl<class llvm::PHINode *> &) c:\src\chromium\src\third_party\llvm\lib\transforms\utils\local.cpp:1378:0
#6 0x00007ff64de933cd llvm::formLCSSAForInstructions(class llvm::SmallVectorImpl<class llvm::Instruction *> &,class llvm::DominatorTree &,class llvm::LoopInfo &) c:\src\chromium\src\third_party\llvm\lib\transforms\utils\lcssa.cpp:228:0
#7 0x00007ff64de91a39 llvm::formLCSSA(class llvm::Loop &,class llvm::DominatorTree &,class llvm::LoopInfo *,class llvm::ScalarEvolution *) c:\src\chromium\src\third_party\llvm\lib\transforms\utils\lcssa.cpp:324:0
#8 0x00007ff64de93766 llvm::formLCSSARecursively(class llvm::Loop &,class llvm::DominatorTree &,class llvm::LoopInfo *,class llvm::ScalarEvolution *) c:\src\chromium\src\third_party\llvm\lib\transforms\utils\lcssa.cpp:346:0
#9 0x00007ff64de93671 formLCSSAOnAllLoops c:\src\chromium\src\third_party\llvm\lib\transforms\utils\lcssa.cpp:355:0
#10 0x00007ff64d98f06d llvm::FPPassManager::runOnFunction(class llvm::Function &) c:\src\chromium\src\third_party\llvm\lib\ir\legacypassmanager.cpp:1520:0
#11 0x00007ff64d662fb7 `anonymous namespace'::CGPassManager::RunPassOnSCC c:\src\chromium\src\third_party\llvm\lib\analysis\callgraphsccpass.cpp:156:0
#12 0x00007ff64d662d50 `anonymous namespace'::CGPassManager::RunAllPassesOnSCC c:\src\chromium\src\third_party\llvm\lib\analysis\callgraphsccpass.cpp:423:0
#13 0x00007ff64d663bd9 `anonymous namespace'::CGPassManager::runOnModule c:\src\chromium\src\third_party\llvm\lib\analysis\callgraphsccpass.cpp:479:0
#14 0x00007ff64d98f4ae `anonymous namespace'::MPPassManager::runOnModule c:\src\chromium\src\third_party\llvm\lib\ir\legacypassmanager.cpp:1597:0
#15 0x00007ff64d98e961 llvm::legacy::PassManagerImpl::run(class llvm::Module &) c:\src\chromium\src\third_party\llvm\lib\ir\legacypassmanager.cpp:1701:0
#16 0x00007ff64e04a769 `anonymous namespace'::EmitAssemblyHelper::EmitAssembly c:\src\chromium\src\third_party\llvm\tools\clang\lib\codegen\backendutil.cpp:802:0
#17 0x00007ff64e04c94f clang::EmitBackendOutput(class clang::DiagnosticsEngine &,class clang::HeaderSearchOptions const &,class clang::CodeGenOptions const &,class clang::TargetOptions const &,class clang::LangOptions const &,class llvm::DataLayout const &,class llvm::Module *,enum clang::BackendAction,class std::unique_ptr<class llvm::raw_pwrite_stream,struct std::default_delete<class llvm::raw_pwrite_stream> >) c:\src\chromium\src\third_party\llvm\tools\clang\lib\codegen\backendutil.cpp:1184:0
#18 0x00007ff64f831793 clang::BackendConsumer::HandleTranslationUnit(class clang::ASTContext &) c:\src\chromium\src\third_party\llvm\tools\clang\lib\codegen\codegenaction.cpp:296:0
#19 0x00007ff64e3ff2fc clang::MultiplexConsumer::HandleTranslationUnit(class clang::ASTContext &) c:\src\chromium\src\third_party\llvm\tools\clang\lib\frontend\multiplexconsumer.cpp:311:0
#20 0x00007ff64ea55d76 clang::ParseAST(class clang::Sema &,bool,bool) c:\src\chromium\src\third_party\llvm\tools\clang\lib\parse\parseast.cpp:162:0
#21 0x00007ff64e3beacd clang::ASTFrontendAction::ExecuteAction(void) c:\src\chromium\src\third_party\llvm\tools\clang\lib\frontend\frontendaction.cpp:1007:0
#22 0x00007ff64e3be95b clang::FrontendAction::Execute(void) c:\src\chromium\src\third_party\llvm\tools\clang\lib\frontend\frontendaction.cpp:908:0
#23 0x00007ff64e3abe58 clang::CompilerInstance::ExecuteAction(class clang::FrontendAction &) c:\src\chromium\src\third_party\llvm\tools\clang\lib\frontend\compilerinstance.cpp:992:0
#24 0x00007ff64e42c8a7 clang::ExecuteCompilerInvocation(class clang::CompilerInstance *) c:\src\chromium\src\third_party\llvm\tools\clang\lib\frontendtool\executecompilerinvocation.cpp:252:0
#25 0x00007ff64c96467c cc1_main(class llvm::ArrayRef<char const *>,char const *,void *) c:\src\chromium\src\third_party\llvm\tools\clang\tools\driver\cc1_main.cpp:221:0
#26 0x00007ff64c960590 ExecuteCC1Tool c:\src\chromium\src\third_party\llvm\tools\clang\tools\driver\driver.cpp:317:0
#27 0x00007ff64c961f9a main c:\src\chromium\src\third_party\llvm\tools\clang\tools\driver\driver.cpp:389:0
#28 0x00007ff64f6b48a5 __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283:0
#29 0x00007ffcbddd8364 (C:\Windows\System32\KERNEL32.DLL+0x8364)
#30 0x00007ffcbdf27091 (C:\Windows\SYSTEM32\ntdll.dll+0x67091)
clang-cl.exe: error: clang frontend command failed due to signal (use -v to see invocation)
clang version 7.0.0 (trunk 324100)
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\src\chromium\src\third_party\llvm-build\Release+Asserts\bin
clang-cl.exe: note: diagnostic msg: PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.
clang-cl.exe: note: diagnostic msg:
********************

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang-cl.exe: note: diagnostic msg: c:\src\temp\lzma_util-841beb.sh
clang-cl.exe: note: diagnostic msg:

********************
ninja: build stopped: subcommand failed.

Deleted: lzma_util-841beb.cpp 9.1 MB

lzma_util-841beb.cpp 9.1 MB View Download

Deleted: lzma_util-841beb.sh 13.0 KB

lzma_util-841beb.sh 13.0 KB View Download

Trying to bisect, but running into a revision where we start getting "The unwind destination does not have an exception handling instruction!" errors.

This was the git bisect output:

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
06b900b9d1dba0663ebcc438dfcabda559453567
f386fe28217eed01437592a1bc85c1e869921480
18a241d7ff63e5e01f98ccd34694fc85242fbb5f
befe17ace98a995b074f65e6feaea6686678adfb
7d8c2eb066de0e7685c243185c974dff21dc73e8
dd9d7eb3e3ca563244eb4095a6b57cc5a8fc6c41
52cef1b35b5f631980c424c37a944b5a865de446
We cannot bisect more!

(This is in the https://github.com/llvm-project/llvm-project-20170507.git repo)


I'm guessing it's this one:

commit 7d8c2eb066de0e7685c243185c974dff21dc73e8 (refs/bisect/skip-7d8c2eb066de0e7685c243185c974dff21dc73e8)
Author: Vedant Kumar <vsk@apple.com>
Date:   Thu Jan 25 21:37:07 2018 +0000

    [Debug] Add dbg.value intrinsics for PHIs created during LCSSA.
    
    This patch is an enhancement to propagate dbg.value information when
    Phis are created on behalf of LCSSA.  I noticed a case where a value
    carried across a loop was reported as <optimized out>.
    
    Specifically this case:
    
      int bar(int x, int y) {
        return x + y;
      }
    
      int foo(int size) {
        int val = 0;
        for (int i = 0; i < size; ++i) {
          val = bar(val, i);  // Both val and i are correct
        }
        return val; // <optimized out>
      }
    
    In the above case, after all of the interesting computation completes
    our value is reported as "optimized out." This change will add a
    dbg.value to correct this.
    
    This patch also moves the dbg.value insertion routine from
    LoopRotation.cpp into Local.cpp, so that we can share it in both places
    (LoopRotation and LCSSA).
    
    Patch by Matt Davis!
    
    Differential Revision: https://reviews.llvm.org/D42551


Yup, reverting confirms it. Let's get a reduced test case...

a.ii:

long a();
class b {
public:
  ~b();
};
typedef struct { int c; } e;
typedef struct {
} d;
class f : public d {
public:
  f(int);
  b g;
};
void h(int *, int *, int, unsigned *, unsigned char **, size_t *, size_t *,
       size_t *, d *, d *);
long j(f, long, struct k *, int *);
int l;
long m() {
  e n;
  int db;
  d o;
  long p;
  unsigned char *q;
  unsigned r;
  size_t u;
  f s(l);
  for (int i;;) {
    size_t offset;
    size_t t;
    int status;
    __try {
      h(&db, &n.c, i, &r, &q, &u, &offset, &t, &s, &o);
    } __except (j(s, _exception_code(), (k *)_exception_info(), &status)) {
      p = 7;
    }
    if (p)
      break;
    p = a();
  }
  return p;
}

$ clang -cc1 -triple x86_64-pc-windows-msvc19.11.0 -emit-obj -munwind-tables -target-cpu x86-64 -gcodeview -debug-info-kind=limited -debugger-tuning=gdb -Os -fms-extensions -fms-compatibility -fms-compatibility-version=19.11 -std=c++14 -fseh-exceptions -x c++ a.ii

https://bugs.llvm.org/show_bug.cgi?id=36238

Revert is in r324247.