New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808431 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
q4



Sign in to add a comment

Cleanup AddNamedGuide in content suggestions primary toolbar

Project Member Reported by justincohen@chromium.org, Feb 2 2018

Issue description

Cleanup/remove/refactor away below in contentsuggestionsheaderview
  AddNamedGuide(kOmniboxGuide, self);
  AddNamedGuide(kBackButtonGuide, self);
  AddNamedGuide(kForwardButtonGuide, self);
  AddNamedGuide(kToolsMenuGuide, self);
  AddNamedGuide(kTabSwitcherGuide, self);
 

Comment 1 by cmasso@google.com, Apr 5 2018

Labels: -Pri-2 Pri-1
Labels: -Q2 Q
Labels: -Q Q3

Comment 4 by marq@chromium.org, Jun 22 2018

Labels: -Q3 Q4
Q3 -> Q4.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9b229cd8b71369bfe70e945a31be9f2969b6327

commit e9b229cd8b71369bfe70e945a31be9f2969b6327
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jun 27 21:49:37 2018

[ios] Show real toolbar on landscape iPhone.

Remove the injected toolbar in the NTP, and shows the real
toolbar when not in split toolbar mode (e.g. landscape iPhone).

Bug:  808431 , 828887,  852443 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib8cfe87702d7a94b66b9622be1e8bc3049e4c392
Reviewed-on: https://chromium-review.googlesource.com/1113543
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570910}
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils_unittest.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.h
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
[modify] https://crrev.com/e9b229cd8b71369bfe70e945a31be9f2969b6327/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator.mm

Status: WontFix (was: Assigned)

Sign in to add a comment