New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808430 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

user-select: all in child elements does not override user-select: none in parent

Reported by c...@dacha.ca, Feb 2 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

Steps to reproduce the problem:
1. See the small snippet here 

.parent {
  user-select: none;
}
.selectable-all {
  user-select: all;
}
<div class="parent">
  <div class="selectable-all">
    Can not select this text
  </div>
</div>

What is the expected behavior?
Any elements explicitly set as user-select: all should override the parent behaviour and allow text selection.

(Note: this works with user-select: text this way still)

What went wrong?
Apps with body set to 'user-select: none' to set selection off globally can now no longer use 'user-select: all' selectively in child elements.

Did this work before? Yes 

Does this work in other browsers? Yes

Chrome version: 63.0.3239.132  Channel: n/a
OS Version: OS X 10.12.6
Flash Version: Shockwave Flash 28.0 r0
 

Comment 2 by lgrey@chromium.org, Feb 2 2018

Components: Blink>CSS
Labels: Needs-Triage-M63 Needs-Bisect
Cc: hu...@vewd.com vamshi.k...@techmahindra.com
Labels: Triaged-ET
Thanks for filing the issue!

@hugoh: Could you please confirm whether this issue is similar to that of https://bugs.chromium.org/p/chromium/issues/detail?id=776233 and help in triaging the issue further.

Comment 5 by hu...@vewd.com, Feb 5 2018

Cc: -hu...@vewd.com yoichio@chromium.org
Labels: -OS-Mac
Owner: hu...@vewd.com
Status: Started (was: Unconfirmed)
Thanks cam@. This is indeed a regression.

Here's a fix: https://chromium-review.googlesource.com/901246.
Labels: -Needs-Bisect
As per comment#5, Developer has already given a fix and started working on the issue. Hence removing Needs-Bisect label.

Thanks!
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f360598ac0e4c31485f163d3ada6fcd728f8c3a

commit 7f360598ac0e4c31485f163d3ada6fcd728f8c3a
Author: Hugo Holgersson <hugoh@vewd.com>
Date: Wed Feb 07 14:46:09 2018

Let user-select: all override parents' user-select: none

This has been broken since Chrome 62 where we landed
https://chromium-review.googlesource.com/570246.

Bug:  808430 
Change-Id: I1c7626778e838b937e7220bd4702fb9eb94cef6a
Reviewed-on: https://chromium-review.googlesource.com/901246
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535002}
[modify] https://crrev.com/7f360598ac0e4c31485f163d3ada6fcd728f8c3a/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/7f360598ac0e4c31485f163d3ada6fcd728f8c3a/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/7f360598ac0e4c31485f163d3ada6fcd728f8c3a/third_party/WebKit/Source/core/input/EventHandlerTest.cpp

Comment 8 by hu...@vewd.com, Feb 13 2018

Status: Fixed (was: Started)

Sign in to add a comment