New issue
Advanced search Search tips

Issue 808424 link

Starred by 1 user
Status: Fixed
Owner:
h...@chromium.org
Closed: Feb 2018
Cc:
est...@chromium.org
thakis@chromium.org
inglorion@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

browser_tests SecurityStateTabHelperTest fails in official builds on Windows

Project Member Reported by h...@chromium.org, Feb 2 2018 
See for example:
https://ci.chromium.org/buildbot/chromium.clang/ToTWin/901
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/78807



[ RUN      ] SecurityStateTabHelperTest.DefaultSecurityLevelOnFilesystemUrl
[5644:2220:0202/000855.556:WARNING:chrome_browser_main_win.cc(615)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=SecurityStateTabHelperTest.DefaultSecurityLevelOnFilesystemUrl --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir5456_14000\results5456_4114\test_results.xml" --test-launcher-summary-output="e:\b\s\w\ioikpamq\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir5456_14000\d5456_31838" --disable-offline-auto-reload --allow-running-insecure-content --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[5644:4444:0202/000855.726:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/ssl/security_state_tab_helper_browsertest.cc(430): error: Expected equality of these values:
  security_state::HTTP_SHOW_WARNING
    Which is: 1
  security_info.security_level
    Which is: 0
[5644:2220:0202/000855.799:INFO:chrome_cryptauth_service.cc(231)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] SecurityStateTabHelperTest.DefaultSecurityLevelOnFilesystemUrl, where TypeParam =  and GetParam() =  (864 ms)

Comment 1 by h...@chromium.org, Feb 2 2018 

First failing build:
https://ci.chromium.org/buildbot/chromium.clang/ToTWin/901

it includes this commit:

---
Add HTTP-Bad Phase 3 experiment to field trial testing config

Some browser tests needed to be updated accordingly. I deleted a couple
that were redundant with tests where the field trial is enabled. For a
few others that only made sense in the pre-field trial world, I just
disabled the feature for them, though we'll want to clean them up
eventually after the field trial launches.

Bug:  807062 
Change-Id: I480b2527375368d6146c1ddace2551dece9ec596
Reviewed-on: https://chromium-review.googlesource.com/891677
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533845}
---

Will verify locally if that's the culprit..

Comment 2 by h...@chromium.org, Feb 2 2018

Cc: est...@chromium.org
Status: Started (was: Assigned)
Yes, that's the one. Reverting here: https://chromium-review.googlesource.com/c/chromium/src/+/899150
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b79ba3c13236d762227ce0201ee0a4cf83c05c5

commit 5b79ba3c13236d762227ce0201ee0a4cf83c05c5
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Feb 02 14:51:42 2018

Revert "Add HTTP-Bad Phase 3 experiment to field trial testing config"

This reverts commit 1b6c18abdf46a3f8ec7461070a4b20be10db89be.

Reason for revert:
This broke two browser_tests in Official Windows builds:
SecurityStateTabHelperTest.DefaultSecurityLevelOnFilesystemUrl
SecurityStateTabHelperTest.DefaultSecurityLevelOnBlobUrl

Original change's description:
> Add HTTP-Bad Phase 3 experiment to field trial testing config
> 
> Some browser tests needed to be updated accordingly. I deleted a couple
> that were redundant with tests where the field trial is enabled. For a
> few others that only made sense in the pre-field trial world, I just
> disabled the feature for them, though we'll want to clean them up
> eventually after the field trial launches.
> 
> Bug:  807062 
> Change-Id: I480b2527375368d6146c1ddace2551dece9ec596
> Reviewed-on: https://chromium-review.googlesource.com/891677
> Reviewed-by: Eric Lawrence <elawrence@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Commit-Queue: Emily Stark <estark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533845}

TBR=jwd@chromium.org,estark@chromium.org,elawrence@chromium.org

Change-Id: I34688c6ef005ac74e79d78a5b8d451790dba96a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  807062 ,  808424 
Reviewed-on: https://chromium-review.googlesource.com/899150
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534048}
[modify] https://crrev.com/5b79ba3c13236d762227ce0201ee0a4cf83c05c5/chrome/browser/ssl/security_state_tab_helper_browsertest.cc
[modify] https://crrev.com/5b79ba3c13236d762227ce0201ee0a4cf83c05c5/testing/variations/fieldtrial_testing_config.json

Comment 4 by h...@chromium.org, Feb 5 2018

Status: Fixed (was: Started)
The bot is green.
►

Sign in to add a comment