Adaptive Toolbar: Trigger the expanded state when the size class change |
|||
Issue descriptionThe expanded state of the toolbar when the omnibox is focused is trigger based on the size class (the toolbar is expanded except in Regular x Regular). When rotating, the animations to expand/contract should be triggered.
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c6764df884c25019cdbf07610b77184ddfed75b commit 7c6764df884c25019cdbf07610b77184ddfed75b Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Feb 21 16:26:12 2018 Trigger expanded/contracted state on rotation When the omnibox is focused, the expanded/contracted state of the toolbar is triggered based on the size class of the application. The rotations while the omnibox is focused need to trigger the changes of state. Bug: 808416 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I554a772b8f38fd6347a126fc44a21ac1aff1ca54 Reviewed-on: https://chromium-review.googlesource.com/926106 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#538127} [modify] https://crrev.com/7c6764df884c25019cdbf07610b77184ddfed75b/ios/chrome/browser/ui/orchestrator/omnibox_focus_orchestrator.h [modify] https://crrev.com/7c6764df884c25019cdbf07610b77184ddfed75b/ios/chrome/browser/ui/orchestrator/omnibox_focus_orchestrator.mm [modify] https://crrev.com/7c6764df884c25019cdbf07610b77184ddfed75b/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn [modify] https://crrev.com/7c6764df884c25019cdbf07610b77184ddfed75b/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm [modify] https://crrev.com/7c6764df884c25019cdbf07610b77184ddfed75b/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.h [modify] https://crrev.com/7c6764df884c25019cdbf07610b77184ddfed75b/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm [add] https://crrev.com/7c6764df884c25019cdbf07610b77184ddfed75b/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller_delegate.h
,
Feb 21 2018
,
Feb 28 2018
The NextAction date has arrived: 2018-02-28
,
Feb 28 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by gambard@chromium.org
, Feb 19 2018