New issue
Advanced search Search tips

Issue 808402 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

WebRtcEventLogManager unaware of crashed RendererProcesses

Project Member Reported by eladalon@chromium.org, Feb 2 2018

Issue description

When a RendererProcess crashes, if any of its associated PeerConnections have active logs in WebRtcEventLogManager, they would be stuck in limbo. We should inform WebRtcEventLogManager when RendererProcesses exit.

This is related to https://bugs.chromium.org/p/chromium/issues/detail?id=805398.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/022ed8aefca41af65bed913a23174eb7f04840aa

commit 022ed8aefca41af65bed913a23174eb7f04840aa
Author: Elad Alon <eladalon@chromium.org>
Date: Tue Feb 06 23:46:39 2018

RenderProcessHost exiting is an implicit PeerConnection removal

When a RenderProcessHost exits clearly or crashes, all of its
PeerConnections should be considered as removed.

Bug: 775415,  805398 ,  808402 
Change-Id: I223e6e867758ef05d896608fbdcc3bc824238dd8
Reviewed-on: https://chromium-review.googlesource.com/899348
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534840}
[modify] https://crrev.com/022ed8aefca41af65bed913a23174eb7f04840aa/content/browser/webrtc/webrtc_event_log_manager.cc
[modify] https://crrev.com/022ed8aefca41af65bed913a23174eb7f04840aa/content/browser/webrtc/webrtc_event_log_manager.h
[modify] https://crrev.com/022ed8aefca41af65bed913a23174eb7f04840aa/content/browser/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/022ed8aefca41af65bed913a23174eb7f04840aa/content/browser/webrtc/webrtc_local_event_log_manager.cc
[modify] https://crrev.com/022ed8aefca41af65bed913a23174eb7f04840aa/content/browser/webrtc/webrtc_local_event_log_manager.h
[modify] https://crrev.com/022ed8aefca41af65bed913a23174eb7f04840aa/content/browser/webrtc/webrtc_remote_event_log_manager.cc
[modify] https://crrev.com/022ed8aefca41af65bed913a23174eb7f04840aa/content/browser/webrtc/webrtc_remote_event_log_manager.h

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/743ea2cb3b876bc44a85587a904328cfe8ce2fed

commit 743ea2cb3b876bc44a85587a904328cfe8ce2fed
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Feb 07 00:09:21 2018

Revert "RenderProcessHost exiting is an implicit PeerConnection removal"

This reverts commit 022ed8aefca41af65bed913a23174eb7f04840aa.

Reason for revert: this broke Cast Audio bots, https://ci.chromium.org/buildbot/chromium.linux/Fuchsia%20ARM64%20Cast%20Audio/4367

Original change's description:
> RenderProcessHost exiting is an implicit PeerConnection removal
> 
> When a RenderProcessHost exits clearly or crashes, all of its
> PeerConnections should be considered as removed.
> 
> Bug: 775415,  805398 ,  808402 
> Change-Id: I223e6e867758ef05d896608fbdcc3bc824238dd8
> Reviewed-on: https://chromium-review.googlesource.com/899348
> Commit-Queue: Elad Alon <eladalon@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534840}

TBR=guidou@chromium.org,terelius@chromium.org,eladalon@chromium.org

Change-Id: I6f33dded2bba23f471c73495518fdded3ccbc3dc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775415,  805398 ,  808402 
Reviewed-on: https://chromium-review.googlesource.com/905638
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534845}
[modify] https://crrev.com/743ea2cb3b876bc44a85587a904328cfe8ce2fed/content/browser/webrtc/webrtc_event_log_manager.cc
[modify] https://crrev.com/743ea2cb3b876bc44a85587a904328cfe8ce2fed/content/browser/webrtc/webrtc_event_log_manager.h
[modify] https://crrev.com/743ea2cb3b876bc44a85587a904328cfe8ce2fed/content/browser/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/743ea2cb3b876bc44a85587a904328cfe8ce2fed/content/browser/webrtc/webrtc_local_event_log_manager.cc
[modify] https://crrev.com/743ea2cb3b876bc44a85587a904328cfe8ce2fed/content/browser/webrtc/webrtc_local_event_log_manager.h
[modify] https://crrev.com/743ea2cb3b876bc44a85587a904328cfe8ce2fed/content/browser/webrtc/webrtc_remote_event_log_manager.cc
[modify] https://crrev.com/743ea2cb3b876bc44a85587a904328cfe8ce2fed/content/browser/webrtc/webrtc_remote_event_log_manager.h

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4ac547420e6715e1da6272408c519898ae09b58

commit b4ac547420e6715e1da6272408c519898ae09b58
Author: Elad Alon <eladalon@chromium.org>
Date: Wed Feb 07 18:13:55 2018

Revert "Revert "RenderProcessHost exiting is an implicit PeerConnection removal""

This reverts commit 743ea2cb3b876bc44a85587a904328cfe8ce2fed.

Reason for revert: Build break fixed; relanding.
Note: The build break was in the underlying CL - fixed by 904905.

Original change's description:
> Revert "RenderProcessHost exiting is an implicit PeerConnection removal"
>
> This reverts commit 022ed8aefca41af65bed913a23174eb7f04840aa.
>
> Reason for revert: this broke Cast Audio bots, https://ci.chromium.org/buildbot/chromium.linux/Fuchsia%20ARM64%20Cast%20Audio/4367
>
> Original change's description:
> > RenderProcessHost exiting is an implicit PeerConnection removal
> >
> > When a RenderProcessHost exits clearly or crashes, all of its
> > PeerConnections should be considered as removed.
> >
> > Bug: 775415,  805398 ,  808402 
> > Change-Id: I223e6e867758ef05d896608fbdcc3bc824238dd8
> > Reviewed-on: https://chromium-review.googlesource.com/899348
> > Commit-Queue: Elad Alon <eladalon@chromium.org>
> > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#534840}
>
>
> Change-Id: I6f33dded2bba23f471c73495518fdded3ccbc3dc
> Bug: 775415,  805398 ,  808402 
> Reviewed-on: https://chromium-review.googlesource.com/905638
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534845}

Change-Id: Ic231cb5466ce1411c8d8d9441ad6105a6da169ff
Bug: 775415,  805398 ,  808402 
Reviewed-on: https://chromium-review.googlesource.com/905607
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535063}
[modify] https://crrev.com/b4ac547420e6715e1da6272408c519898ae09b58/content/browser/webrtc/webrtc_event_log_manager.cc
[modify] https://crrev.com/b4ac547420e6715e1da6272408c519898ae09b58/content/browser/webrtc/webrtc_event_log_manager.h
[modify] https://crrev.com/b4ac547420e6715e1da6272408c519898ae09b58/content/browser/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/b4ac547420e6715e1da6272408c519898ae09b58/content/browser/webrtc/webrtc_local_event_log_manager.cc
[modify] https://crrev.com/b4ac547420e6715e1da6272408c519898ae09b58/content/browser/webrtc/webrtc_local_event_log_manager.h
[modify] https://crrev.com/b4ac547420e6715e1da6272408c519898ae09b58/content/browser/webrtc/webrtc_remote_event_log_manager.cc
[modify] https://crrev.com/b4ac547420e6715e1da6272408c519898ae09b58/content/browser/webrtc/webrtc_remote_event_log_manager.h

Status: Fixed (was: Assigned)

Sign in to add a comment