New issue
Advanced search Search tips

Issue 808390 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Indirect-leak in content::RenderFrameImpl::WillSendRequest

Project Member Reported by ClusterFuzz, Feb 2 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6048726125379584

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Indirect-leak
Crash Address: 
Crash State:
  content::RenderFrameImpl::WillSendRequest
  blink::LocalFrameClientImpl::DispatchWillSendRequest
  blink::FrameFetchContext::PrepareRequest
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=478007:478121

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6048726125379584

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 2 2018

Components: Blink Internals>Core
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Components: -Blink Blink>Loader
Owner: yhirano@chromium.org
Status: Assigned (was: Untriaged)
Tentatively assigning to me.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/830f47c978601a1150a24f3b92fadddd44cb45ed

commit 830f47c978601a1150a24f3b92fadddd44cb45ed
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Mon Feb 19 05:33:43 2018

Make WebURLRequest::ExtraData ownership transfer explicit

This is probably not going to fix the leak but will make things
clearer.

Bug:  808390 
Change-Id: I625ed2fde63d1eb1bb09fcb5ed3e522929d9f025
Reviewed-on: https://chromium-review.googlesource.com/923447
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537581}
[modify] https://crrev.com/830f47c978601a1150a24f3b92fadddd44cb45ed/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/830f47c978601a1150a24f3b92fadddd44cb45ed/content/renderer/pepper/url_request_info_util.cc
[modify] https://crrev.com/830f47c978601a1150a24f3b92fadddd44cb45ed/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/830f47c978601a1150a24f3b92fadddd44cb45ed/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/830f47c978601a1150a24f3b92fadddd44cb45ed/content/renderer/service_worker/service_worker_fetch_context_impl.cc
[modify] https://crrev.com/830f47c978601a1150a24f3b92fadddd44cb45ed/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/830f47c978601a1150a24f3b92fadddd44cb45ed/content/renderer/service_worker/worker_fetch_context_impl.cc
[modify] https://crrev.com/830f47c978601a1150a24f3b92fadddd44cb45ed/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/830f47c978601a1150a24f3b92fadddd44cb45ed/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/830f47c978601a1150a24f3b92fadddd44cb45ed/third_party/WebKit/Source/platform/exported/WebURLRequestTest.cpp
[modify] https://crrev.com/830f47c978601a1150a24f3b92fadddd44cb45ed/third_party/WebKit/public/platform/WebURLRequest.h

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0d88ce6a54b2846b84f9a331382f5a812d64114

commit a0d88ce6a54b2846b84f9a331382f5a812d64114
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Mon Feb 19 16:45:10 2018

Remove ResourceRequest::ExtraData

This doesn't change the behavior.

Bug:  808390 
Change-Id: I54f04cd5aa7b69e25d9fa72fc82489ac9e006d28
Reviewed-on: https://chromium-review.googlesource.com/923923
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537666}
[modify] https://crrev.com/a0d88ce6a54b2846b84f9a331382f5a812d64114/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/a0d88ce6a54b2846b84f9a331382f5a812d64114/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h

Status: WontFix (was: Assigned)
ClusterFuzz says it's unreproducible, so I'm closing this bug.
 Issue 820611  has been merged into this issue.
Cc: yhirano@chromium.org
 Issue 823129  has been merged into this issue.
 Issue 825669  has been merged into this issue.
 Issue 825559  has been merged into this issue.
 Issue 847335  has been merged into this issue.
 Issue 848660  has been merged into this issue.

Sign in to add a comment