New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808383 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 758782
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 807616



Sign in to add a comment

Stacking suffixes in histograms.xml get ugly and non-trivial quickly.

Project Member Reported by gab@chromium.org, Feb 2 2018

Issue description

TaskScheduler histograms are taking advantage of suffixes to break stats into different processes/pools/task types but it's becoming hard to reason about the config ( issue 807616 ).

It would be very nice if we could just define which histograms are basis and which one stack on top of which base without having to explicitly list all variants of that base. Listing all variants is not only tedious, it becomes error-prone and hard to read when multiple suffixes stack.

How about something like

<affected-histogram-suffix name="MySuffix"/>

which just generates all the variants of this suffix recursively applied on top of the variants of MySuffix?
 
Cc: -isherman@chromium.org -rkaplow@chromium.org
I believe that Steve (holte@) had some ideas for cleaning up the suffix specification to be much more readable and intuitive.

Comment 2 by holte@chromium.org, Feb 6 2018

My idea was to switch to defining histogram patterns:

https://bugs.chromium.org/p/chromium/issues/detail?id=758782

Comment 3 by gab@chromium.org, Feb 6 2018

That looks much more usable to me indeed!

Le mar. 6 févr. 2018 21 h 24, holte via monorail <
monorail+v2.3891487502@chromium.org> a écrit :
Mergedinto: 758782
Status: Duplicate (was: Untriaged)

Sign in to add a comment