wpt/custom-elements/htmlconstructor/newtarget.html fails for custom built-in elements |
||
Issue descriptionChrome Version: ToT OS: All but iOS What steps will reproduce the problem? (1) Enable chrome://flags/#enable-experimental-web-platform-features (2) Open https://w3c-test.org/custom-elements/htmlconstructor/newtarget.html What is the expected result? All tests should PASS. What happens instead? Four tests for custom built-in elements FAIL. Please use labels and text to provide additional information. When a prototype is invalid, we always set HTMLElement prototype. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp?type=cs&sq=package:chromium&l=114
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58660fa684deca20a939c10db89e9382cc527f69 commit 58660fa684deca20a939c10db89e9382cc527f69 Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Feb 13 05:41:32 2018 custom-element: Use correct active function object in HtmlConstructor In V8HTMLConstructor::HtmlConstructor, we use HTMLElement as constructor function but that is not true if we construct custom-elements. This patch modifies the function to use appropriate Element constructor. Bug: 808365 Change-Id: I4eb7d7a5a6d0c89306c0396c4e91edb54a2b462c Reviewed-on: https://chromium-review.googlesource.com/910474 Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#536260} [delete] https://crrev.com/9a8fe169f149f452058f4d7a4bdefc3d92fc85db/third_party/WebKit/LayoutTests/external/wpt/custom-elements/htmlconstructor/newtarget-expected.txt [modify] https://crrev.com/58660fa684deca20a939c10db89e9382cc527f69/third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp
,
Feb 13 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by tkent@chromium.org
, Feb 5 2018Status: Assigned (was: Available)