Policies with path variables should handle correctly the presence or absence of trailing slashes in them |
||||
Issue descriptionCurrently it seems that Chrome will append a second slash if a path variable contains a trailing slash at least for the root directory (according to reporter https://productforums.google.com/forum/#!topic/chrome-admins/aW3Zz54uWow ) We should fix that so no matter what a variable expands to it is properly handled.
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5156ea734c64658e63b7ccf8b6ec107d8889f744 commit 5156ea734c64658e63b7ccf8b6ec107d8889f744 Author: Julian Pastarmov <pastarmovj@chromium.org> Date: Mon Apr 16 15:55:34 2018 Fix double trailing slashes for Windows special path expansion. BUG= 808359 Change-Id: Ia95a6f90086f0aa8ea62e81838f1ae95c7c6496c Reviewed-on: https://chromium-review.googlesource.com/1012065 Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#550969} [modify] https://crrev.com/5156ea734c64658e63b7ccf8b6ec107d8889f744/chrome/install_static/policy_path_parser.cc
,
Apr 17 2018
,
Apr 17 2018
Julian@ Could you please help us with repro steps to verify the fix from TE end. Thank You...
,
Apr 17 2018
You should be able to test by changing the location of the documents folder locally to c:\ or d:\ by following the instruction here http://www.dummies.com/computers/operating-systems/windows-10/how-to-change-the-location-of-user-folders-in-windows-10/ and then set a policy like the DowloadDirectory policy to say ${documents}\test and check that the policy value is resolved to d:\test and not to d:\\test in chrome://policy and that downloads indeed land in this directory.
,
Apr 17 2018
Verified this issue on Debian Rodete and Win 10 with chrome #68.0.3398.0 and the fix is working as expected. hence adding verified labels Attaching the screen-cast for reference. Note: Soon will verify this issue on Mac and update the behavior
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5156ea734c64658e63b7ccf8b6ec107d8889f744 commit 5156ea734c64658e63b7ccf8b6ec107d8889f744 Author: Julian Pastarmov <pastarmovj@chromium.org> Date: Mon Apr 16 15:55:34 2018 Fix double trailing slashes for Windows special path expansion. BUG= 808359 Change-Id: Ia95a6f90086f0aa8ea62e81838f1ae95c7c6496c Reviewed-on: https://chromium-review.googlesource.com/1012065 Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#550969} [modify] https://crrev.com/5156ea734c64658e63b7ccf8b6ec107d8889f744/chrome/install_static/policy_path_parser.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by pastarmovj@chromium.org
, Apr 16 2018