New issue
Advanced search Search tips

Issue 808341 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in blink::LayoutObject::MaybeClearIsScrollAnchorObject

Project Member Reported by ClusterFuzz, Feb 2 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6489697262764032

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  blink::LayoutObject::MaybeClearIsScrollAnchorObject
  blink::RootFrameViewport::SetLayoutViewport
  blink::PaintLayerScrollableArea::Dispose
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=533693:533696

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6489697262764032

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 2 2018

Labels: Test-Predator-Auto-Owner
Owner: szager@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/fe8c4db4003022f5cb12506a15cc78ea6633bbdf ([RootLayerScrolls] Flip RuntimeEnabledFeatures flag to experimental).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 2 2018

Labels: M-65
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 2 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 2 2018

Labels: Pri-1
Components: Blink>Layout
Cc: skobes@chromium.org
Cc: szager@chromium.org
Owner: pnoland@chromium.org
@pnoland, do you think this is a dupe of issue 806631?
Potentially, since that only got merged to M65 a few hours ago. I'll re-run the "fixed" task.
This doesn't look like a duplicate to me.  This bug is happening during document tear-down.

I'm going to speculatively add a null-check after this line:

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp?rcl=1fb4857ddb46a7e5babc1a64830cdd97ce7d1d12&l=217

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d635e268594cc7db9f4e214ec16ffc7385647bc

commit 7d635e268594cc7db9f4e214ec16ffc7385647bc
Author: Stefan Zager <szager@chromium.org>
Date: Sat Feb 03 01:12:45 2018

Speculative fix for crash in document tear-down.

BUG= 808341 
R=skobes@chromium.org

Change-Id: I298ffd2134ec5021682bc443a5c6a9ba4a9cc13c
Reviewed-on: https://chromium-review.googlesource.com/899928
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534226}
[modify] https://crrev.com/7d635e268594cc7db9f4e214ec16ffc7385647bc/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

Project Member

Comment 11 by sheriffbot@chromium.org, Feb 3 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Labels: -M-65 M-66
Cc: bokan@chromium.org chrishtr@chromium.org
I can't reproduce this using the clusterfuzz reproduce tool.
Cc: pnoland@chromium.org
Owner: bokan@chromium.org
Project Member

Comment 16 by ClusterFuzz, Feb 10 2018

ClusterFuzz has detected this issue as fixed in range 535692:535694.

Detailed report: https://clusterfuzz.com/testcase?key=6489697262764032

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  blink::LayoutObject::MaybeClearIsScrollAnchorObject
  blink::RootFrameViewport::SetLayoutViewport
  blink::PaintLayerScrollableArea::Dispose
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=533693:533696
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=535692:535694

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6489697262764032

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 17 by ClusterFuzz, Feb 10 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6489697262764032 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 18 by bokan@chromium.org, Feb 10 2018

Interesting, looks like a clang roll fixed this? Seems strange...should I poke at this more or do we take clusterfuzz's word for it?
Project Member

Comment 19 by sheriffbot@chromium.org, Feb 11 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 21 by sheriffbot@chromium.org, May 20 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment