New issue
Advanced search Search tips

Issue 808337 link

Starred by 1 user
Status: Fixed
Owner:
dtseng@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"BackgroundTest.ActiveDescendantUpdates" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 2 2018 
"BackgroundTest.ActiveDescendantUpdates" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMQsSBUZsYWtlIiZCYWNrZ3JvdW5kVGVzdC5BY3RpdmVEZXNjZW5kYW50VXBkYXRlcww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14ef2a6ba7af9bb8d84bc309588ad20760ff86cd

commit 14ef2a6ba7af9bb8d84bc309588ad20760ff86cd
Author: Chris Pickel <sfiera@chromium.org>
Date: Fri Feb 02 09:20:29 2018

Revert "Force updates to related nodes"

This reverts commit f0baa069df76e8efffee79107676930e49336073.

Reason for revert: "BackgroundTest.ActiveDescendantUpdates" is flaky. Since it appears to have been added in this CL, reverting for dtseng to take another look.

Original change's description:
> Force updates to related nodes
> 
> Test: chromevox_tests. Prior to the change,
> BackgroundTest.ActiveDescendantUpdates fails because 'Selected' is not spoken.
> 
> Compute text content for list items without names
> 
> Chrome doesn't compute descendant name on focus.
> 
> Test: manually on twitter.com using j/k. Verify all text gets read.
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Ie75dff41f98b8aa3904e435afa4bd245b9771cce
> Reviewed-on: https://chromium-review.googlesource.com/891676
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533960}

TBR=dtseng@chromium.org,nektar@chromium.org

Bug:  808337 
Change-Id: I4f838f27aa81a607bcb83934bec0dc321d336466
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/897789
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534006}
[modify] https://crrev.com/14ef2a6ba7af9bb8d84bc309588ad20760ff86cd/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/14ef2a6ba7af9bb8d84bc309588ad20760ff86cd/content/renderer/accessibility/render_accessibility_impl.cc
[modify] https://crrev.com/14ef2a6ba7af9bb8d84bc309588ad20760ff86cd/content/test/data/accessibility/event/aria-combo-box-expand-expected-mac.txt
[modify] https://crrev.com/14ef2a6ba7af9bb8d84bc309588ad20760ff86cd/content/test/data/accessibility/event/aria-combo-box-expand-expected-win.txt
[modify] https://crrev.com/14ef2a6ba7af9bb8d84bc309588ad20760ff86cd/content/test/data/accessibility/event/aria-combo-box-next-expected-mac.txt
[modify] https://crrev.com/14ef2a6ba7af9bb8d84bc309588ad20760ff86cd/content/test/data/accessibility/event/aria-combo-box-next-expected-win.txt
[modify] https://crrev.com/14ef2a6ba7af9bb8d84bc309588ad20760ff86cd/content/test/data/accessibility/event/aria-treeitem-focus-expected-mac.txt
[modify] https://crrev.com/14ef2a6ba7af9bb8d84bc309588ad20760ff86cd/content/test/data/accessibility/event/checked-state-changed-expected-mac.txt

Comment 2 by sfiera@chromium.org, Feb 2 2018

Labels: -Sheriff-Chromium
Owner: dtseng@chromium.org
Status: Assigned (was: Untriaged)
Reassigning to dtseng@ for another look.

Comment 3 by dtseng@chromium.org, Feb 2 2018

Status: fixed (was: Assigned)
This isn't flakey anymore because it got reverted.
►

Sign in to add a comment