New issue
Advanced search Search tips

Issue 808332 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

video_JpegDecodeAcceleratorPerf failed due to ectool returning non-zero status

Project Member Reported by jcliang@chromium.org, Feb 2 2018

Issue description

Failing on eve with: 

(https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/173382066-chromeos-test/chromeos6-row3-rack11-host1)

01/30 07:10:00.967 WARNI|              test:0637| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 631, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 837, in _call_test_function
    raise error.UnhandledTestFail(e)
UnhandledTestFail: Unhandled TypeError: 'NoneType' object has no attribute '__getitem__'
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 831, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 495, in execute
    dargs)
  File "/usr/local/autotest/common_lib/test.py", line 362, in _call_run_once_with_retry
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 400, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/cros/chrome_binary_test.py", line 145, in wrapper
    return func(*args, **kargs)
  File "/usr/local/autotest/tests/video_JpegDecodeAcceleratorPerf/video_JpegDecodeAcceleratorPerf.py", line 66, in run_once
    keyvals = self.test_power()
  File "/usr/local/autotest/tests/video_JpegDecodeAcceleratorPerf/video_JpegDecodeAcceleratorPerf.py", line 119, in test_power
    percent_initial_charge = self._power_status.percent_current_charge()
  File "/usr/local/autotest/cros/power/power_status.py", line 467, in percent_current_charge
    return self.battery[0].charge_now * 100 / \
TypeError: 'NoneType' object has no attribute '__getitem__'

01/30 07:10:00.970 DEBUG|              test:0642| Running cleanup for test.

Failing on peach_pit with:

(https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/173455004-chromeos-test/chromeos6-row2-rack10-host13)

01/30 15:35:01.057 WARNI|              test:0637| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 631, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 831, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 495, in execute
    dargs)
  File "/usr/local/autotest/common_lib/test.py", line 362, in _call_run_once_with_retry
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 400, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/cros/chrome_binary_test.py", line 145, in wrapper
    return func(*args, **kargs)
  File "/usr/local/autotest/tests/video_JpegDecodeAcceleratorPerf/video_JpegDecodeAcceleratorPerf.py", line 66, in run_once
    keyvals = self.test_power()
  File "/usr/local/autotest/tests/video_JpegDecodeAcceleratorPerf/video_JpegDecodeAcceleratorPerf.py", line 114, in test_power
    if not power_utils.charge_control_by_ectool(is_charge=False):
  File "/usr/local/autotest/cros/power/power_utils.py", line 189, in charge_control_by_ectool
    utils.run(ec_cmd_discharge)
  File "/usr/local/autotest/common_lib/utils.py", line 748, in run
    "Command returned non-zero exit status")
CmdError: Command <ectool chargecontrol discharge> failed, rc=1, Command returned non-zero exit status
* Command: 
    ectool chargecontrol discharge
Exit status: 1
Duration: 0.0151350498199

stderr:
ioctl -1, errno 74 (Bad message), EC result 1 (INVALID_COMMAND)
Is AC connected?
 
I will catch the error and retry it 3 times.
Components: Tests>Fails Internals>GPU>Video
Issue 812212 has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/71cf95107cc094ba606fd12cbbcefbb4df577952

commit 71cf95107cc094ba606fd12cbbcefbb4df577952
Author: Moja Hsu <mojahsu@chromium.org>
Date: Wed Feb 14 18:50:23 2018

video_JpegDecodeAcceleratorPerf: Fix power utility issues

There are 2 issues for power utility.
1. ectool returning non-zero status.
2. There is no power sysfs interface for battery.
This CL fixs both of them.
It will retry ectool command 3 times for non-zero status.
It will check if the battery is valid before use the power status
utility.

BUG= chromium:808332 
TEST=Test it on peach_pi for case 1.
Test it on eve for case 2.
Test it on samus for normal case.

Change-Id: I5d0f467c2d317c30d6fcd36b7d27d7693754f0f4
Reviewed-on: https://chromium-review.googlesource.com/901044
Commit-Ready: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[modify] https://crrev.com/71cf95107cc094ba606fd12cbbcefbb4df577952/client/cros/power/power_utils.py
[modify] https://crrev.com/71cf95107cc094ba606fd12cbbcefbb4df577952/client/site_tests/video_JpegDecodeAcceleratorPerf/video_JpegDecodeAcceleratorPerf.py

Comment 5 by mcasas@chromium.org, Feb 26 2018

mojahsu@ did the fix in #4 make it to the bots? stainless is red still. 
Can you add an estimate NextAction below plz? Thanks

https://stainless.corp.google.com/search?exclude_cts=true&exclude_non_release=true&board=%5Eeve%24&test=%5Evideo_&view=matrix&col=build&row=test&first_date=2018-02-20&last_date=2018-02-26
mcasas@
Did you mean the eve part?
Looks like the battery is not good of the eve machine.
The machine(chromeos6-row3-rack11-host1) doesn't have the battery interface.
"/sys/class/power_supply/BAT0"
And I found we use the same machine to run the case for the latest 5 times.

Can we replace the eve of chromeos6-row3-rack11-host1 or run the case on another eve board(e.g. chromeos15-row1-rack9-host5)

Status: Fixed (was: Assigned)
I think we should open another issue for the eve part.

Sign in to add a comment