New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 808325 link

Starred by 1 user
Status: Fixed
Owner:
█ trchen@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
wangxianzhu@chromium.org
vmp...@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 771643



Sign in to add a comment

[SPv175] virtual/gpu/fast/canvas/canvas-css-clip-path.html failure

Project Member Reported by trchen@chromium.org, Feb 2 2018 
With https://chromium-review.googlesource.com/c/chromium/src/+/896607 applied,
the virtual/gpu version of fast/canvas/canvas-css-clip-path.html fails.

It seems to be some transform space or paint offset related issue. (clip path applied in the wrong space?)

Comment 1 by wangxianzhu@chromium.org, Feb 2 2018

Blocking: 771643

Comment 2 by wangxianzhu@chromium.org, Mar 15 2018

Owner: trchen@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1aa123c1bc2c35f0b66a3457020a1a210f617798

commit 1aa123c1bc2c35f0b66a3457020a1a210f617798
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Tue Mar 27 03:43:30 2018

[Blink/SPv175] Fix child clipping mask snapping bug

The clip rect calculated by PaintLayerClipper already included all
paint offset. We inadvertantly added paint offset again to child
clipping mask bounds prior to this CL, resulting in subpixel
accumulation being counted twice. This CL fixes it.

As a side change, this CL also creates paint offset translation
for composited replaced elements. Previously we only create paint
offset translation for composited blocks, which broken assumptions
in other part of the code.

BUG= 815358 , 808325 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I17ca32d366942e12f9364a42205d6fc44171bf9c
Reviewed-on: https://chromium-review.googlesource.com/974161
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545995}
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-clip-subpixel-accumulation-expected.html
[add] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-clip-subpixel-accumulation.html
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-mask-canvas-all-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-mask-canvas-with-mask-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-mask-canvas-with-shadow-expected.png
[delete] https://crrev.com/79edda647add552849397a3d643505442febda8c/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/prefer_compositing_to_lcd_text/compositing/overflow/border-radius-composited-subframe-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/border-radius-composited-subframe-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-mask-canvas-all-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-mask-canvas-with-mask-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-mask-canvas-with-shadow-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/border-radius-composited-subframe-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-mask-canvas-all-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-mask-canvas-with-mask-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-mask-canvas-with-shadow-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Comment 4 by trchen@chromium.org, Mar 27 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment