We decided to have separate interfaces of SkewX and SkewY. New Specs: https://drafts.css-houdini.org/css-typed-om-1/#cssskewx https://drafts.css-houdini.org/css-typed-om-1/#cssskewy Should be straightforward as CSSSkew is already implemented.
i will take this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9845aa037bf3415c7b9cd62494a5dbadb9a698d commit c9845aa037bf3415c7b9cd62494a5dbadb9a698d Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Mon Feb 05 01:55:57 2018 [css-typed-om] ay which is 0 should omit when serialize a CSSSkew when ay value is 0, second value should omit when serialized. https://drafts.css-houdini.org/css-typed-om-1/#serialize-a-cssskew Bug: 808321 Change-Id: I933a42d46b12578acf66ca2065c4761319cb086b Reviewed-on: https://chromium-review.googlesource.com/899703 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#534313} [modify] https://crrev.com/c9845aa037bf3415c7b9cd62494a5dbadb9a698d/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html [modify] https://crrev.com/c9845aa037bf3415c7b9cd62494a5dbadb9a698d/third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0c6ecb65bba57b1d66198270e44b565e719b0c9 commit f0c6ecb65bba57b1d66198270e44b565e719b0c9 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Tue Feb 06 00:00:58 2018 [css-typed-om] Implement CSSSkewX CSSSkewX and CSSSkewY was added in spec. because result of "skew(X,Y)" is different from "skewX(X) skewY(Y)". first of all, CSSSkewX was added at this CL. and CSSSkewY is going to add at next patch. https://drafts.css-houdini.org/css-typed-om-1/#cssskewx Bug: 808321 Change-Id: I9214b06047f100c88999cba796d6c803545092c0 Reviewed-on: https://chromium-review.googlesource.com/899883 Reviewed-by: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#534541} [modify] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/interfaces-expected.txt [modify] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/resources/testhelper.js [modify] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-normalization/transformvalue-normalization.tentative.html [modify] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html [add] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssSkewX.tentative.html [modify] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/transform.html [modify] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/Source/core/core_idl_files.gni [modify] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/Source/core/css/BUILD.gn [modify] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp [add] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/Source/core/css/cssom/CSSSkewX.cpp [add] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/Source/core/css/cssom/CSSSkewX.h [add] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/Source/core/css/cssom/CSSSkewX.idl [modify] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp [modify] https://crrev.com/f0c6ecb65bba57b1d66198270e44b565e719b0c9/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4958a32a20326946bd634ee6f4ab0a09342ef7f commit a4958a32a20326946bd634ee6f4ab0a09342ef7f Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Fri Feb 09 00:41:39 2018 [css-typed-om] Implement CSSSkewY CSSSkewX and CSSSkewY was added in spec. because result of "skew(X,Y)" is different from "skewX(X) skewY(Y)". CSSSkewX was already added at before CL. https://drafts.css-houdini.org/css-typed-om-1/#cssskewy Bug: 808321 Change-Id: I2909a34b571647968bc463d55e3a3b38e3c03de3 Reviewed-on: https://chromium-review.googlesource.com/904086 Reviewed-by: nainar <nainar@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#535595} [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/interfaces-expected.txt [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/resources/testhelper.js [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-normalization/transformvalue-normalization.tentative.html [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html [add] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-subclasses/cssSkewY.tentative.html [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/transform.html [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/Source/core/core_idl_files.gni [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/Source/core/css/BUILD.gn [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/Source/core/css/cssom/CSSSkew.h [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/Source/core/css/cssom/CSSSkewX.cpp [add] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/Source/core/css/cssom/CSSSkewY.cpp [add] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/Source/core/css/cssom/CSSSkewY.h [add] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/Source/core/css/cssom/CSSSkewY.idl [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp [modify] https://crrev.com/a4958a32a20326946bd634ee6f4ab0a09342ef7f/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h
Comment 1 by hs1217....@samsung.com
, Feb 2 2018Owner: hs1217....@samsung.com
Status: Assigned (was: Available)