New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
not on chrome
Closed: Oct 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 808287: Build meta-target 'all' on Fuchsia bots, instead of 'gn_all'

Reported by w...@chromium.org, Feb 2 2018 Project Member

Issue description

We presently build the 'gn_all' target for Fuchsia, rather than 'all', because 'all' includes various build targets that have not yet been ported to Fuchsia, or never will be.

We should migrate from gn_all->all, since gn_all is really just an internal detail of the build system; all other platforms build 'all', or a list of specific targets, as necessary.

- Targets which we do not expect to need to port to Fuchsia should be made conditional on 'is_fuchsia' in the relevant GN rule.

- Targets which we haven't yet ported should be made conditional on 'is_fuchsia', with a bug filed for us to port them, and a TODO.
 

Comment 1 by w...@chromium.org, Feb 9 2018

Labels: -Pri-2 Pri-1

Comment 2 by bugdroid1@chromium.org, Feb 13 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/00cecb98041d9d97df966467b690d1df8de37803

commit 00cecb98041d9d97df966467b690d1df8de37803
Author: Wez <wez@chromium.org>
Date: Tue Feb 13 08:23:48 2018

Disable use of libevent under Fuchsia.

Bug:  chromium:808287 
Change-Id: I1c29c5f2d13ad06904724fd95d476b23ae7097ac
Reviewed-on: https://webrtc-review.googlesource.com/50520
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21994}
[modify] https://crrev.com/00cecb98041d9d97df966467b690d1df8de37803/webrtc.gni

Comment 3 by w...@chromium.org, Apr 26 2018

Labels: -Pri-1 -M-67 M-68 Pri-2

Comment 4 by w...@chromium.org, May 23 2018

Labels: -M-68 M-69

Comment 5 by w...@chromium.org, Jul 27 2018

Labels: -M-69 M-70

Comment 7 by w...@chromium.org, Oct 16

Labels: -M-70 M-72

Comment 8 by bugdroid1@chromium.org, Oct 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfad347caf3ef3e0fbfabe6c39b68fe5846c5122

commit bfad347caf3ef3e0fbfabe6c39b68fe5846c5122
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Oct 24 20:02:29 2018

fuchsia: define cases for url_fixer_unittest

(Probably could use some improvement to make file:/// work more
Fuchsia-like, but this at least makes the file compile.)

Bug:  808287 
Change-Id: Id4476f6ec9d2f37006df439a72855587bb18b4c3
Reviewed-on: https://chromium-review.googlesource.com/c/1298178
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602413}
[modify] https://crrev.com/bfad347caf3ef3e0fbfabe6c39b68fe5846c5122/components/url_formatter/url_fixer_unittest.cc

Comment 9 by bugdroid1@chromium.org, Oct 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/664dd09a707cf0d8e44a1f54acecfe67107d831d

commit 664dd09a707cf0d8e44a1f54acecfe67107d831d
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Oct 24 20:04:45 2018

fuchsia: Fix #include for ntohl/htonl

Bug:  808287 ,  898088 
Change-Id: I7aa9dd73aa405e32a46118dfe8474c7849471caf
Reviewed-on: https://chromium-review.googlesource.com/c/1297460
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602417}
[modify] https://crrev.com/664dd09a707cf0d8e44a1f54acecfe67107d831d/components/safe_browsing/db/v4_rice.cc

Comment 10 by scottmg@chromium.org, Oct 24

Cc: -scottmg@chromium.org w...@chromium.org
Owner: scottmg@chromium.org
Status: Started (was: Assigned)
This v8 roll failure was time-wasting enough that I'm going to take this and try to finish it off now.

Comment 11 by bugdroid1@chromium.org, Oct 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd9524ccf2b7adf6ca3fe5eea56e6c12fa6fe515

commit dd9524ccf2b7adf6ca3fe5eea56e6c12fa6fe515
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Oct 24 21:36:04 2018

fuchsia: Make OfferStoreUnmaskedCards follow most other OSs

Bug:  808287 
Change-Id: I6a8e1af6e4073a3a064a94976b17271f9d7330ca
Reviewed-on: https://chromium-review.googlesource.com/c/1298348
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602464}
[modify] https://crrev.com/dd9524ccf2b7adf6ca3fe5eea56e6c12fa6fe515/components/autofill/core/browser/personal_data_manager_unittest.cc

Comment 12 by bugdroid1@chromium.org, Oct 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e70c69e2c55074c3a6ebfeafd7508938f134bdd

commit 5e70c69e2c55074c3a6ebfeafd7508938f134bdd
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Oct 24 21:56:48 2018

fuchsia: Make sender_pipe_unittest use the posix version

I'm not sure if this will be correct until these tests can run, but this
will at least compile, as opposed to using the Windows version.

Bug:  808287 
Change-Id: I2f112f9ab2575abc88d1495ba324cdcc15cde4a7
Reviewed-on: https://chromium-review.googlesource.com/c/1298299
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602475}
[modify] https://crrev.com/5e70c69e2c55074c3a6ebfeafd7508938f134bdd/components/services/heap_profiling/public/cpp/sender_pipe_unittest.cc

Comment 13 by bugdroid1@chromium.org, Oct 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d48fb29ab09fc4e5ca6de0b94a98cc1e972554f2

commit d48fb29ab09fc4e5ca6de0b94a98cc1e972554f2
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Oct 24 22:31:47 2018

fuchsia: Add branch to GetCurrentCountryID() in template_url_prepopulate_data

Bug:  808287 
Change-Id: Id50a9e5e45428fe155d0de4059486b14ee71f11b
Reviewed-on: https://chromium-review.googlesource.com/c/1298414
Commit-Queue: Scott Graham <scottmg@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602495}
[modify] https://crrev.com/d48fb29ab09fc4e5ca6de0b94a98cc1e972554f2/components/search_engines/template_url_prepopulate_data.cc

Comment 14 by bugdroid1@chromium.org, Oct 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f9bd41f891bd708257b8729d1f108820d09f9a1

commit 5f9bd41f891bd708257b8729d1f108820d09f9a1
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Oct 24 22:36:45 2018

fuchsia: Use UTF8 filename path for in_memory_database

Bug:  808287 
Change-Id: I412c47c632f3dc3042e324939e9a241522cb7a33
Reviewed-on: https://chromium-review.googlesource.com/c/1297277
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602498}
[modify] https://crrev.com/5f9bd41f891bd708257b8729d1f108820d09f9a1/components/history/core/browser/in_memory_database.cc

Comment 15 by bugdroid1@chromium.org, Oct 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c272eac6cfd4a88914f8e71c95de70963eac7b5

commit 7c272eac6cfd4a88914f8e71c95de70963eac7b5
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Oct 24 22:41:19 2018

Add missing include to mojo_fuzzer_message_dump.cc

This happens to fail on Fuchsia, but is just generally not IWYU.

Bug:  808287 
Change-Id: I46c8527f0becf79d10c4e960a083e4b9e8eb8bc7
Reviewed-on: https://chromium-review.googlesource.com/c/1298241
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602502}
[modify] https://crrev.com/7c272eac6cfd4a88914f8e71c95de70963eac7b5/mojo/public/tools/fuzzers/mojo_fuzzer_message_dump.cc

Comment 16 by bugdroid1@chromium.org, Oct 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/fbc5c555976f639017c58a40b24f0040a2a21106

commit fbc5c555976f639017c58a40b24f0040a2a21106
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Oct 24 23:28:29 2018

fuchsia: Disable GL

I think we'll only need Vulkan. But in any case, the GL code doesn't
build, so disable it for now.

Bug:  chromium:808287 
Change-Id: I08f8cd09e67d91c08b7632e54bbdc6a11ee57014
Reviewed-on: https://chromium-review.googlesource.com/c/1298381
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>

[modify] https://crrev.com/fbc5c555976f639017c58a40b24f0040a2a21106/gni/angle.gni

Comment 17 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13b6bcb862835f1f40f531801add7e1733b0cd94

commit 13b6bcb862835f1f40f531801add7e1733b0cd94
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Oct 25 00:56:08 2018

fuchsia: Remove unnecessary dependencies in cast_media_shlib_common, add dep on null_video

stream_mixer.h was causing a dep on base, but just remove that include
because it's no longer needed.

null_video dependency required to let libcast_media_1.0_avsync link.

Bug:  808287 
Change-Id: If86449b7ebb394907b41820c21d1cc805569c717
Reviewed-on: https://chromium-review.googlesource.com/c/1298633
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602546}
[modify] https://crrev.com/13b6bcb862835f1f40f531801add7e1733b0cd94/chromecast/media/cma/backend/video/BUILD.gn
[modify] https://crrev.com/13b6bcb862835f1f40f531801add7e1733b0cd94/chromecast/media/cma/backend/video/cast_media_shlib_common.cc

Comment 18 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1dee2d17907dc7f396822f51cc5293823c64fcf

commit c1dee2d17907dc7f396822f51cc5293823c64fcf
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Oct 25 01:35:24 2018

fuchsia: Add missing dependency on sdk:input

fuchsia/input_event_dispatcher_unittest.cc depends on the input FIDL.

Bug:  808287 
Change-Id: I1d1acca03db6770ac6ee554925a057f09decd9fd
Reviewed-on: https://chromium-review.googlesource.com/c/1298505
Commit-Queue: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602562}
[modify] https://crrev.com/c1dee2d17907dc7f396822f51cc5293823c64fcf/ui/events/BUILD.gn

Comment 19 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31e73a0050e8b36fef67c3a5dab99aa2d5badd6a

commit 31e73a0050e8b36fef67c3a5dab99aa2d5badd6a
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 25 01:44:10 2018

Roll src/third_party/angle c3ee7ec01dda..fbc5c555976f (1 commits)

https://chromium.googlesource.com/angle/angle.git/+log/c3ee7ec01dda..fbc5c555976f


git log c3ee7ec01dda..fbc5c555976f --date=short --no-merges --format='%ad %ae %s'
2018-10-24 scottmg@chromium.org fuchsia: Disable GL


Created with:
  gclient setdep -r src/third_party/angle@fbc5c555976f

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:808287 
TBR=jmadill@chromium.org

Change-Id: Iee38e5576bca9ec57c2c74ed2540e08aefbad6fd
Reviewed-on: https://chromium-review.googlesource.com/c/1298262
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602565}
[modify] https://crrev.com/31e73a0050e8b36fef67c3a5dab99aa2d5badd6a/DEPS

Comment 20 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c70beebd16d9af37a6a239c02558177ab3a2ac86

commit c70beebd16d9af37a6a239c02558177ab3a2ac86
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Oct 25 16:36:00 2018

fuchsia: Fix compilation of download_database.cc

Fuchsia is more POSIX-y than Windows-y in this instance.

Bug:  808287 
Change-Id: Ie881c4136d2946c703a464e60d1b107ab4582ac8
Reviewed-on: https://chromium-review.googlesource.com/c/1298327
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602744}
[modify] https://crrev.com/c70beebd16d9af37a6a239c02558177ab3a2ac86/components/history/OWNERS
[modify] https://crrev.com/c70beebd16d9af37a6a239c02558177ab3a2ac86/components/history/core/browser/download_database.cc

Comment 21 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfb659ec2d09fd1a1d2d60f791f6e8bce13be389

commit dfb659ec2d09fd1a1d2d60f791f6e8bce13be389
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Oct 25 16:40:36 2018

fuchsia: Add branch to GetPlatformString() in variations_service.cc

Bug:  808287 
Change-Id: I0124f24e96f54cc9ef7a96c7eeb788142da63ecc
Reviewed-on: https://chromium-review.googlesource.com/c/1298343
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602748}
[modify] https://crrev.com/dfb659ec2d09fd1a1d2d60f791f6e8bce13be389/components/variations/service/variations_service.cc

Comment 22 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/f26e290e33571b4fabfe71b96bf2987b8e85df98

commit f26e290e33571b4fabfe71b96bf2987b8e85df98
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Oct 25 17:13:00 2018

fuchsia: Stub out timing and memory functions

This functionality isn't (currently) available on Fuchsia from the OS.

Bug:  chromium:808287 
Change-Id: If017bc762448c437b74cb03587ba35da5d131c75
Reviewed-on: https://webrtc-review.googlesource.com/c/107760
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#25373}
[modify] https://crrev.com/f26e290e33571b4fabfe71b96bf2987b8e85df98/rtc_base/cpu_time.cc
[modify] https://crrev.com/f26e290e33571b4fabfe71b96bf2987b8e85df98/rtc_base/memory_usage.cc

Comment 23 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf77d35d71f3edb2d2450a43ee97423de2efdab4

commit bf77d35d71f3edb2d2450a43ee97423de2efdab4
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Oct 25 17:50:54 2018

fuchsia: Add stub of BluetoothTestFuchsia

Add a stub of BluetoothTestFuchsia to allow the test files to compile.
Of course, they won't work until someone has time to work on a real
implementation of bluetooth for Fuchsia.

Bug:  808287 
Change-Id: Icc3f5f1325b7be44ae96086b82b6ba0efff3b47e
Reviewed-on: https://chromium-review.googlesource.com/c/1298085
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602782}
[modify] https://crrev.com/bf77d35d71f3edb2d2450a43ee97423de2efdab4/device/BUILD.gn
[modify] https://crrev.com/bf77d35d71f3edb2d2450a43ee97423de2efdab4/device/bluetooth/bluetooth_adapter_unittest.cc
[modify] https://crrev.com/bf77d35d71f3edb2d2450a43ee97423de2efdab4/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/bf77d35d71f3edb2d2450a43ee97423de2efdab4/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
[modify] https://crrev.com/bf77d35d71f3edb2d2450a43ee97423de2efdab4/device/bluetooth/bluetooth_remote_gatt_descriptor_unittest.cc
[modify] https://crrev.com/bf77d35d71f3edb2d2450a43ee97423de2efdab4/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc
[modify] https://crrev.com/bf77d35d71f3edb2d2450a43ee97423de2efdab4/device/bluetooth/test/bluetooth_gatt_server_test.h
[add] https://crrev.com/bf77d35d71f3edb2d2450a43ee97423de2efdab4/device/bluetooth/test/bluetooth_test_fuchsia.cc
[add] https://crrev.com/bf77d35d71f3edb2d2450a43ee97423de2efdab4/device/bluetooth/test/bluetooth_test_fuchsia.h
[modify] https://crrev.com/bf77d35d71f3edb2d2450a43ee97423de2efdab4/device/fido/ble/fido_ble_connection_unittest.cc

Comment 24 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/532006cfd3c308f52d14d05fce67dd232a70e67a

commit 532006cfd3c308f52d14d05fce67dd232a70e67a
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Oct 25 18:50:53 2018

Fix #include in run_testserver

This happens to show up on Fuchsia, but is a general IWYU for
base::DirectoryExists().

Bug:  808287 
Change-Id: I26608991148aa2d381fe3f162a666a53722d4b57
Reviewed-on: https://chromium-review.googlesource.com/c/1298358
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602815}
[modify] https://crrev.com/532006cfd3c308f52d14d05fce67dd232a70e67a/net/tools/testserver/run_testserver.cc

Comment 25 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdf87103b6d01dc8b7fa3d7120fa03a53e0b1864

commit fdf87103b6d01dc8b7fa3d7120fa03a53e0b1864
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Oct 25 19:00:22 2018

fuchsia: Fix sign-compare warning in divsufsort

ALPHABET_SIZE, BUCKET_A_SIZE, and BUCKET_B_SIZE are defined in terms
of UINT8_MAX which is unsigned (at least on Fuchsia) and fairly small
((UINT8_MAX+1)^2). saidx_t and saint_t are signed.

[25568->415/26982 ~1000] CXX obj/courgette/divsufsort/divsufsort.o
FAILED: obj/courgette/divsufsort/divsufsort.o
/usr/local/google/home/scottmg/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/courgette/divsufsort/divsufsort.o.d -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DUSE_AURA=1 -DUSE_OZONE=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DFUCHSIA_SDK_VERSION=05a1d1f99b5b8b4b8edb3097564b0653ec0f52bd -DCR_CLANG_REVISION=\"344066-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=344254 -DCR_LIBCXXABI_REVISION=344215 -D_LIBCPP_ENABLE_NODISCARD -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen -I../../third_party/fuchsia-sdk/sdk/pkg/async/include -I../../third_party/fuchsia-sdk/sdk/pkg/fdio/include -I../../third_party/fuchsia-sdk/sdk/pkg/zx/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers --target=x86_64-fuchsia -fno-sanitize=safe-stack -m64 -march=x86-64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize -Wno-defaulted-function-deleted -O0 -fno-omit-frame-pointer -g2 -ggnu-pubnames -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-shorten-64-to-32 -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=c++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../third_party/fuchsia-sdk/sdk/arch/x64/sysroot -fvisibility-inlines-hidden -c ../../courgette/third_party/divsufsort/divsufsort.cc -o obj/courgette/divsufsort/divsufsort.o
../../courgette/third_party/divsufsort/divsufsort.cc:60:16: error: comparison of integers of different signs: 'divsuf::saidx_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
  for(i = 0; i < BUCKET_A_SIZE; ++i) { bucket_A[i] = 0; }
             ~ ^ ~~~~~~~~~~~~~
../../courgette/third_party/divsufsort/divsufsort.cc:61:16: error: comparison of integers of different signs: 'divsuf::saidx_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
  for(i = 0; i < BUCKET_B_SIZE; ++i) { bucket_B[i] = 0; }
             ~ ^ ~~~~~~~~~~~~~
../../courgette/third_party/divsufsort/divsufsort.cc:87:32: error: comparison of integers of different signs: 'divsuf::saint_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
  for(c0 = 0, i = 0, j = 0; c0 < ALPHABET_SIZE; ++c0) {
                            ~~ ^ ~~~~~~~~~~~~~
../../courgette/third_party/divsufsort/divsufsort.cc:91:25: error: comparison of integers of different signs: 'divsuf::saint_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
    for(c1 = c0 + 1; c1 < ALPHABET_SIZE; ++c1) {
                     ~~ ^ ~~~~~~~~~~~~~
4 errors generated.

Bug:  808287 
Change-Id: I57c416b029803d56157152f73c71742e9ba61ab9
Reviewed-on: https://chromium-review.googlesource.com/c/1298232
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602817}
[modify] https://crrev.com/fdf87103b6d01dc8b7fa3d7120fa03a53e0b1864/courgette/third_party/divsufsort/README.chromium
[modify] https://crrev.com/fdf87103b6d01dc8b7fa3d7120fa03a53e0b1864/courgette/third_party/divsufsort/divsufsort.cc

Comment 26 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55729963b1e454fc0011ac95f008e0ceb7f7976e

commit 55729963b1e454fc0011ac95f008e0ceb7f7976e
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Oct 25 21:24:25 2018

fuchsia: Avoid unnecessary references to WindowEventFilter

The link error I'm trying to avoid is this:

[122->5/127 ~1] SOLINK ./libviews.so
FAILED: libviews.so libviews.so.TOC lib.unstripped/libviews.so
python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --strip=../../third_party/eu-strip/bin/eu-strip --sofile="./lib.unstripped/libviews.so" --tocfile="./libviews.so.TOC" --output="./libviews.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,-z,max-page-size=4096 -Wl,--icf=all -Wl,--color-diagnostics --target=aarch64-fuchsia -Wl,-z,stack-size=0x800000 -Wl,--no-as-needed -lfdio -Wl,--as-needed -Werror -Wl,--gdb-index -nostdlib++ --sysroot=../../third_party/fuchsia-sdk/sdk/arch/arm64/sysroot -L../../third_party/fuchsia-sdk/sdk/arch/arm64/lib -o "./lib.unstripped/libviews.so" -Wl,-soname="libviews.so" @"./libviews.so.rsp"
ld.lld: error: undefined symbol: views::WindowEventFilter::WindowEventFilter(views::DesktopWindowTreeHost*)
>>> referenced by memory:3118 (../../buildtools/third_party/libc++/trunk/include/memory:3118)
>>>               obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&))

ld.lld: error: undefined symbol: views::WindowEventFilter::SetWmMoveResizeHandler(ui::WmMoveResizeHandler*)
>>> referenced by desktop_window_tree_host_platform.cc:106 (../../ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc:106)
>>>               obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&))
clang: error: ld.lld command failed with exit code 1 (use -v to see invocation)

I'm not sure what the correct approach is; DesktopWindowTreeHostPlatform
depends on WindowEventFilter which uses LinuxUI.

Since there's no available non-client area on Fuchsia currently, not
doing this seems correct for the time being. Or does Fuchsia really need
its own DesktopWindowTreeHostFuchsia implementation?

Bug:  808287 
Change-Id: I2af683415ea00147607eb4236540d8d3e8643603
Reviewed-on: https://chromium-review.googlesource.com/c/1298554
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602860}
[modify] https://crrev.com/55729963b1e454fc0011ac95f008e0ceb7f7976e/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc

Comment 27 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8380640da64ef32f5d27e2582f7d97a427ff7876

commit 8380640da64ef32f5d27e2582f7d97a427ff7876
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Oct 25 22:01:48 2018

Revert "fuchsia: Avoid unnecessary references to WindowEventFilter"

This reverts commit 55729963b1e454fc0011ac95f008e0ceb7f7976e.

Reason for revert: Apparently this broke Fuchsia Cast somehow (on waterfall but not CQ)

Original change's description:
> fuchsia: Avoid unnecessary references to WindowEventFilter
> 
> The link error I'm trying to avoid is this:
> 
> [122->5/127 ~1] SOLINK ./libviews.so
> FAILED: libviews.so libviews.so.TOC lib.unstripped/libviews.so
> python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --strip=../../third_party/eu-strip/bin/eu-strip --sofile="./lib.unstripped/libviews.so" --tocfile="./libviews.so.TOC" --output="./libviews.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,-z,max-page-size=4096 -Wl,--icf=all -Wl,--color-diagnostics --target=aarch64-fuchsia -Wl,-z,stack-size=0x800000 -Wl,--no-as-needed -lfdio -Wl,--as-needed -Werror -Wl,--gdb-index -nostdlib++ --sysroot=../../third_party/fuchsia-sdk/sdk/arch/arm64/sysroot -L../../third_party/fuchsia-sdk/sdk/arch/arm64/lib -o "./lib.unstripped/libviews.so" -Wl,-soname="libviews.so" @"./libviews.so.rsp"
> ld.lld: error: undefined symbol: views::WindowEventFilter::WindowEventFilter(views::DesktopWindowTreeHost*)
> >>> referenced by memory:3118 (../../buildtools/third_party/libc++/trunk/include/memory:3118)
> >>>               obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&))
> 
> ld.lld: error: undefined symbol: views::WindowEventFilter::SetWmMoveResizeHandler(ui::WmMoveResizeHandler*)
> >>> referenced by desktop_window_tree_host_platform.cc:106 (../../ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc:106)
> >>>               obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&))
> clang: error: ld.lld command failed with exit code 1 (use -v to see invocation)
> 
> I'm not sure what the correct approach is; DesktopWindowTreeHostPlatform
> depends on WindowEventFilter which uses LinuxUI.
> 
> Since there's no available non-client area on Fuchsia currently, not
> doing this seems correct for the time being. Or does Fuchsia really need
> its own DesktopWindowTreeHostFuchsia implementation?
> 
> Bug:  808287 
> Change-Id: I2af683415ea00147607eb4236540d8d3e8643603
> Reviewed-on: https://chromium-review.googlesource.com/c/1298554
> Commit-Queue: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602860}

TBR=sky@chromium.org,scottmg@chromium.org,thomasanderson@chromium.org

Change-Id: I00a7631118f58db9413c391416079c4f94a974ae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  808287 
Reviewed-on: https://chromium-review.googlesource.com/c/1300101
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602887}
[modify] https://crrev.com/8380640da64ef32f5d27e2582f7d97a427ff7876/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc

Comment 28 by bugdroid1@chromium.org, Oct 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6003da075b745865943174c7d44a18f05097e32

commit d6003da075b745865943174c7d44a18f05097e32
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 25 23:09:22 2018

Roll src/third_party/webrtc 6c6c9df99db6..8c27ccac7597 (4 commits)

https://webrtc.googlesource.com/src.git/+log/6c6c9df99db6..8c27ccac7597


git log 6c6c9df99db6..8c27ccac7597 --date=short --no-merges --format='%ad %ae %s'
2018-10-25 benwright@webrtc.org Promotoing webrtc::CryptoOptions to RTCConfiguration.
2018-10-25 benwright@webrtc.org Fixes use after free error when setting a new FrameEncryptor on ChannelSend.
2018-10-25 scottmg@chromium.org fuchsia: Stub out timing and memory functions
2018-10-25 jamiewalch@google.com Disable probe delay warning in release builds.


Created with:
  gclient setdep -r src/third_party/webrtc@8c27ccac7597

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG= chromium:808287 ,chromium:888038
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I6bda4329d38b26019758d06a637ffa44712f12c2
Reviewed-on: https://chromium-review.googlesource.com/c/1299590
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602918}
[modify] https://crrev.com/d6003da075b745865943174c7d44a18f05097e32/DEPS

Comment 29 by bugdroid1@chromium.org, Oct 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b2683898e4d3d20112093acedd9c9d7c03fa447

commit 1b2683898e4d3d20112093acedd9c9d7c03fa447
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Oct 26 02:57:15 2018

Reland "fuchsia: Avoid unnecessary references to WindowEventFilter"

This reverts commit 8380640da64ef32f5d27e2582f7d97a427ff7876.

> > fuchsia: Avoid unnecessary references to WindowEventFilter
> >
> > The link error I'm trying to avoid is this:
> >
> > [122->5/127 ~1] SOLINK ./libviews.so
> > FAILED: libviews.so libviews.so.TOC lib.unstripped/libviews.so
> > python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --strip=../../third_party/eu-strip/bin/eu-strip --sofile="./lib.unstripped/libviews.so" --tocfile="./libviews.so.TOC" --output="./libviews.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,-z,max-page-size=4096 -Wl,--icf=all -Wl,--color-diagnostics --target=aarch64-fuchsia -Wl,-z,stack-size=0x800000 -Wl,--no-as-needed -lfdio -Wl,--as-needed -Werror -Wl,--gdb-index -nostdlib++ --sysroot=../../third_party/fuchsia-sdk/sdk/arch/arm64/sysroot -L../../third_party/fuchsia-sdk/sdk/arch/arm64/lib -o "./lib.unstripped/libviews.so" -Wl,-soname="libviews.so" @"./libviews.so.rsp"
> > ld.lld: error: undefined symbol: views::WindowEventFilter::WindowEventFilter(views::DesktopWindowTreeHost*)
> > >>> referenced by memory:3118 (../../buildtools/third_party/libc++/trunk/include/memory:3118)
> > >>>               obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&))
> >
> > ld.lld: error: undefined symbol: views::WindowEventFilter::SetWmMoveResizeHandler(ui::WmMoveResizeHandler*)
> > >>> referenced by desktop_window_tree_host_platform.cc:106 (../../ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc:106)
> > >>>               obj/ui/views/views/desktop_window_tree_host_platform.o:(views::DesktopWindowTreeHostPlatform::OnNativeWidgetCreated(views::Widget::InitParams const&))
> > clang: error: ld.lld command failed with exit code 1 (use -v to see invocation)
> >
> > I'm not sure what the correct approach is; DesktopWindowTreeHostPlatform
> > depends on WindowEventFilter which uses LinuxUI.
> >
> > Since there's no available non-client area on Fuchsia currently, not
> > doing this seems correct for the time being. Or does Fuchsia really need
> > its own DesktopWindowTreeHostFuchsia implementation?
> >
> > Bug:  808287 
> > Change-Id: I2af683415ea00147607eb4236540d8d3e8643603
> > Reviewed-on: https://chromium-review.googlesource.com/c/1298554
> > Commit-Queue: Scott Graham <scottmg@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#602860}
>
> TBR=sky@chromium.org,scottmg@chromium.org,thomasanderson@chromium.org
>
> Change-Id: I00a7631118f58db9413c391416079c4f94a974ae
> Bug:  808287 
> Reviewed-on: https://chromium-review.googlesource.com/c/1300101
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602887}

TBR=sky@chromium.org,scottmg@chromium.org,thomasanderson@chromium.org

Change-Id: I3302a0dec267ebec369d53ec8906c1c31cd12ba0
Bug:  808287 
Reviewed-on: https://chromium-review.googlesource.com/c/1300110
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602975}
[modify] https://crrev.com/1b2683898e4d3d20112093acedd9c9d7c03fa447/ui/views/BUILD.gn
[modify] https://crrev.com/1b2683898e4d3d20112093acedd9c9d7c03fa447/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc
[modify] https://crrev.com/1b2683898e4d3d20112093acedd9c9d7c03fa447/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.h

Comment 30 by bugdroid1@chromium.org, Oct 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3c4223c6684dddccaea99ad06331e3738da7b2

commit 8b3c4223c6684dddccaea99ad06331e3738da7b2
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Oct 26 15:51:18 2018

fuchsia: Switch building from gn_all to all

Bug:  808287 
Change-Id: I98e37d5baba3fd8784bbcaf8dcdafdf7f83518d1
Reviewed-on: https://chromium-review.googlesource.com/c/1296838
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603103}
[modify] https://crrev.com/8b3c4223c6684dddccaea99ad06331e3738da7b2/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/8b3c4223c6684dddccaea99ad06331e3738da7b2/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/8b3c4223c6684dddccaea99ad06331e3738da7b2/testing/buildbot/waterfalls.pyl

Comment 31 by scottmg@chromium.org, Oct 26

Status: Fixed (was: Started)
Waterfall is building 'all', fyi is still red from test runs, but compile of 'all' in both debug (component) and release (non-component) is happy.

Comment 32 by bugdroid1@chromium.org, Nov 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c9dc31e5681b16ed416b66ef26a67e9eaaffd12

commit 4c9dc31e5681b16ed416b66ef26a67e9eaaffd12
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Nov 07 19:52:41 2018

fuchsia: Update docs with note about building all

Bug:  808287 
TBR: jeremymanson
Change-Id: I252d13864e5749c0e9c15bf2e8b3771d2fdd3683
Reviewed-on: https://chromium-review.googlesource.com/c/1324106
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606137}
[modify] https://crrev.com/4c9dc31e5681b16ed416b66ef26a67e9eaaffd12/docs/fuchsia_build_instructions.md

Sign in to add a comment