New issue
Advanced search Search tips

Issue 808286 link

Starred by 0 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add UMA error tracking to SQLitePersistentCookieStore and register with finch-chirp

Project Member Reported by rdsmith@chromium.org, Feb 2 2018

Issue description

The SQLitePersistentCookieStore does not track and report database errors through UMA, leaving chromium development blind to problems occurring in that context (e.g.  issue 800414 ,  issue 795827 ).  UMA error tracking should be added to the persistent cookie store.
 

Comment 1 by mmenke@chromium.org, Feb 14 2018

Labels: Network-Triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/846cbb632c692ae7ccb7e75f7d5b1ccb5cba0983

commit 846cbb632c692ae7ccb7e75f7d5b1ccb5cba0983
Author: Maks Orlovich <morlovich@chromium.org>
Date: Wed Mar 07 16:17:06 2018

SQLitePersistentCookieStore: report decryption trouble to UMA

This in particular targets the case where it's likely getting stuck
(defined as taking >= 60s per entry), but also includes cases where
it fails, since that's basically same spot.

Bug: 809199, 808286
Change-Id: Id7f2157e352914dc7aa163938d260362c14afba6
Reviewed-on: https://chromium-review.googlesource.com/951925
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541451}
[modify] https://crrev.com/846cbb632c692ae7ccb7e75f7d5b1ccb5cba0983/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/846cbb632c692ae7ccb7e75f7d5b1ccb5cba0983/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/846cbb632c692ae7ccb7e75f7d5b1ccb5cba0983/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/245d8f76fa39341a09ccdb6baf0f8e6d489fb3ab

commit 245d8f76fa39341a09ccdb6baf0f8e6d489fb3ab
Author: Maks Orlovich <morlovich@chromium.org>
Date: Tue Mar 27 12:52:16 2018

SQLitePersistentCookieStore: Don't DCHECK on commit errors, report them

(Report them to UMA, that is)

Bug: 787679, 808286
Change-Id: I7ad003574fd62c3429024b7ce45e55a2b39662bb
Reviewed-on: https://chromium-review.googlesource.com/975823
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546091}
[modify] https://crrev.com/245d8f76fa39341a09ccdb6baf0f8e6d489fb3ab/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/245d8f76fa39341a09ccdb6baf0f8e6d489fb3ab/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/245d8f76fa39341a09ccdb6baf0f8e6d489fb3ab/tools/metrics/histograms/histograms.xml

Bulk edit**

This bug has the label Postmortem-Followup but has not been updated in 3+ weeks. We are working on a new workflow to improve postmortem followthrough. Postmortems and postmortem bugs are very important in making sure we don't repeat prior mistakes and for making Chrome better for all.

We will be taking a closer look at these bugs in the coming weeks. Please take some time to work on this, reassign, or close if the issue has been fixed. Thank you.

Sign in to add a comment