Issue metadata
Sign in to add a comment
|
URL #fragment / #hash navigation is broken for links opened in background tabs
Reported by
vsemozhe...@gmail.com,
Feb 2 2018
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3336.5 Safari/537.36 Example URL: Any with hash links Steps to reproduce the problem: 1. Open any doc in https://nodejs.org/api/ 2. Click on any TOC link with middle mouse button 3. Wait till background page is loaded 4. Go to background tab What is the expected behavior? The page is scrolled to the #hash What went wrong? The page is scrolled to the very bottom Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes At least 65.0.3325.31 (Official Build) dev (64-bit) is OK now, but 66 seemed OK 2-3 days ago Does this work in other browsers? Yes Chrome version: 66.0.3336.5 Channel: canary OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: 28.0.0.152 Shift + left-button-click (open in new foreground window) is OK. If you go to the background tab immediately after middle mouse button clicking (so that navigation/scrolling takes effect in the active tab) scrolling is also OK.
,
Feb 2 2018
Bisect info: 533355 (good) - 533360 (bad) https://chromium.googlesource.com/chromium/src/+log/195fd5c7..b15f7f04?pretty=fuller Suspecting r533357 = a438b798b2cbd89888bd2539335a0b790c2f799a = https://crrev.com/c/894262 by samans@chromium.org "content: Send ResizeParams in ViewMsg_WasShown" Landed in 66.0.3336.0
,
Feb 2 2018
Thanks woxxom@ samans@, could you take a look?
,
Feb 2 2018
FWIW, the same happens when JS calls scroll functions in background tab, like element.scrollIntoView()
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d709592b7ce56fc6106d3a30cf28447c44f755f6 commit d709592b7ce56fc6106d3a30cf28447c44f755f6 Author: Saman Sami <samans@chromium.org> Date: Sat Feb 03 00:38:10 2018 Revert "content: Send ResizeParams in ViewMsg_WasShown" This reverts commit a438b798b2cbd89888bd2539335a0b790c2f799a. Reason for revert: Causes crbug.com/808282 Original change's description: > content: Send ResizeParams in ViewMsg_WasShown > > Don't send any WasResized messages when the RenderWidgetHostImpl is > hidden, and once it's visible, send the ResizeParams along with the > WasShown message. When a WasShown message that has ResizeParams > arrives in the renderer, the resize will be performed before setting > the visibility to true. This CL makes it easier to send a new > LocalSurfaceId to an evicted background tab when it becomes visible. > (Allocating a new ID will happen in a subsequent CL) > > Bug: 777881 > Change-Id: Ibbc1a3604fb93806059d6beb3e51872f5aeaad4c > Reviewed-on: https://chromium-review.googlesource.com/894262 > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533357} TBR=fsamuel@chromium.org,tsepez@chromium.org,piman@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 777881 , 808282 Change-Id: I71691467ef1868042d43bc4280bb55a0d71e859d Reviewed-on: https://chromium-review.googlesource.com/899924 Reviewed-by: Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#534211} [modify] https://crrev.com/d709592b7ce56fc6106d3a30cf28447c44f755f6/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/d709592b7ce56fc6106d3a30cf28447c44f755f6/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/d709592b7ce56fc6106d3a30cf28447c44f755f6/content/browser/renderer_host/render_widget_host_unittest.cc [modify] https://crrev.com/d709592b7ce56fc6106d3a30cf28447c44f755f6/content/common/view_messages.h [modify] https://crrev.com/d709592b7ce56fc6106d3a30cf28447c44f755f6/content/renderer/render_frame_impl_browsertest.cc [modify] https://crrev.com/d709592b7ce56fc6106d3a30cf28447c44f755f6/content/renderer/render_widget.cc [modify] https://crrev.com/d709592b7ce56fc6106d3a30cf28447c44f755f6/content/renderer/render_widget.h
,
Feb 3 2018
Seems fixed in 66.0.3338.0. Thank you!
,
Feb 3 2018
Thanks you for verifying. I'm closing this bug. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by kochi@chromium.org
, Feb 2 2018Labels: -Type-Bug RegressedIn-66 Needs-Bisect Type-Bug-Regression