Overlapping set of changes: r533690 to r533696
http://test-results.appspot.com/revision_range?start=533690&end=533696

The only components/ change in the range is "Reland "Remove influence of group name on NTPPopularSites studies"" https://chromium.googlesource.com/chromium/src/+/ffc93ab8afc61f4bfea18b81c8b8cc4290dc238a


The end of the logcat for component_unittests also points toward this CL: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.android%2FLollipop_Phone_Tester%2F18417%2F%2B%2Frecipes%2Fsteps%2Fcomponents_unittests_on_Android%2F0%2Fstdout


I  958.989s run_tests_on_device(030e2c4408d4f861)  >>ScopedMainEntryLogger
I  958.989s run_tests_on_device(030e2c4408d4f861)  Note: Google Test filter = MostVisitedSitesTest/MostVisitedSitesTest.ShouldIncludeTileForHomePage/1
I  958.989s run_tests_on_device(030e2c4408d4f861)  [==========] Running 1 test from 1 test case.
I  958.989s run_tests_on_device(030e2c4408d4f861)  [----------] Global test environment set-up.
I  958.989s run_tests_on_device(030e2c4408d4f861)  [----------] 1 test from MostVisitedSitesTest/MostVisitedSitesTest
I  958.989s run_tests_on_device(030e2c4408d4f861)  [ RUN      ] MostVisitedSitesTest/MostVisitedSitesTest.ShouldIncludeTileForHomePage/1
I  958.989s run_tests_on_device(030e2c4408d4f861)  [FATAL:jni_android.cc(137)] Failed to find class org/chromium/components/ntptiles/MostVisitedSites
I  958.989s run_tests_on_device(030e2c4408d4f861)  #00 0x9e3d5c31 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x0149cc31
I  958.989s run_tests_on_device(030e2c4408d4f861)  #01 0x9e3b6383 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x0147d383
I  958.989s run_tests_on_device(030e2c4408d4f861)  #02 0x9e3b63d3 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x0147d3d3
I  958.989s run_tests_on_device(030e2c4408d4f861)  #03 0xa20c3d4d /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x0518ad4d
I  958.989s run_tests_on_device(030e2c4408d4f861)  #04 0xa20c536d /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x0518c36d
I  958.990s run_tests_on_device(030e2c4408d4f861)  #05 0x9e898b81 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x0195fb81
I  958.990s run_tests_on_device(030e2c4408d4f861)  #06 0x9f3480df /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x0240f0df
I  958.990s run_tests_on_device(030e2c4408d4f861)  #07 0x9f34850f /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x0240f50f
I  958.990s run_tests_on_device(030e2c4408d4f861)  #08 0x9f348715 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x0240f715
I  958.990s run_tests_on_device(030e2c4408d4f861)  #09 0x9f34af49 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x02411f49
I  958.990s run_tests_on_device(030e2c4408d4f861)  #10 0x9f34ad91 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x02411d91
I  958.990s run_tests_on_device(030e2c4408d4f861)  #11 0xa0d17b45 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x03ddeb45
I  958.990s run_tests_on_device(030e2c4408d4f861)  #12 0xa0d20d4d /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x03de7d4d
I  958.990s run_tests_on_device(030e2c4408d4f861)  #13 0x9ed0702d /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x01dce02d
I  958.990s run_tests_on_device(030e2c4408d4f861)  #14 0xa0c658bd /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so+0x03d2c8bd
I  958.990s run_tests_on_device(030e2c4408d4f861)  
I  958.990s run_tests_on_device(030e2c4408d4f861)  [ERROR:test_suite.cc(298)] Currently running: MostVisitedSitesTest/MostVisitedSitesTest.ShouldIncludeTileForHomePage/1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d246e1f498fad94f09275b8fd186a1c1b6a71fed

commit d246e1f498fad94f09275b8fd186a1c1b6a71fed
Author: Theresa <twellington@chromium.org>
Date: Fri Feb 02 01:05:18 2018

Revert "Reland "Remove influence of group name on NTPPopularSites studies""

This reverts commit ffc93ab8afc61f4bfea18b81c8b8cc4290dc238a.

Reason for revert: This change broke It broke components_unittests on multiple bots. See  crbug.com/808260 .

Original change's description:
> Reland "Remove influence of group name on NTPPopularSites studies"
> 
> This is a reland of 1a544c783e00bf6adb51be7590fee71f5c4a4185.
> 
> Original change's description:
> > Remove influence of group name on NTPPopularSites studies
> > 
> > Recently, a misnamed study (see deleted test config) caused the feature
> > to fall back to the default popular sites. This isn't a big problem but
> > when it was finally named correctly, the names of the groups disabled
> > all popular sites.
> > 
> > Popular sites should not be so easy to disable. Therefore, remove the
> > group name condition.
> > 
> > A forced cmd line flag should cover all possible cases and make the
> > intention very clear. This is already in place and remains untouched.
> > 
> > Bug: 794329
> > Change-Id: I71458d41de6d0e0d5f0d8fcde1b636b0fe18618c
> > Reviewed-on: https://chromium-review.googlesource.com/827072
> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#528301}
> 
> Bug: 794329
> Change-Id: I0c391668095cd66be012f0d1d483ff0970cbb018
> Reviewed-on: https://chromium-review.googlesource.com/888560
> Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533690}

TBR=treib@chromium.org,gayane@chromium.org,mastiz@chromium.org,fhorschig@chromium.org

Change-Id: I2ca9733fc9fbb2efa667e44af25ab204f24c2efd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 794329,  808260 
Reviewed-on: https://chromium-review.googlesource.com/898494
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533879}
[modify] https://crrev.com/d246e1f498fad94f09275b8fd186a1c1b6a71fed/chrome/browser/about_flags.cc
[modify] https://crrev.com/d246e1f498fad94f09275b8fd186a1c1b6a71fed/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d246e1f498fad94f09275b8fd186a1c1b6a71fed/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d246e1f498fad94f09275b8fd186a1c1b6a71fed/components/ntp_tiles/constants.cc
[modify] https://crrev.com/d246e1f498fad94f09275b8fd186a1c1b6a71fed/components/ntp_tiles/constants.h
[modify] https://crrev.com/d246e1f498fad94f09275b8fd186a1c1b6a71fed/components/ntp_tiles/field_trial.cc
[modify] https://crrev.com/d246e1f498fad94f09275b8fd186a1c1b6a71fed/components/ntp_tiles/most_visited_sites_unittest.cc
[modify] https://crrev.com/d246e1f498fad94f09275b8fd186a1c1b6a71fed/components/ntp_tiles/popular_sites_impl_unittest.cc
[modify] https://crrev.com/d246e1f498fad94f09275b8fd186a1c1b6a71fed/components/ntp_tiles/switches.cc
[modify] https://crrev.com/d246e1f498fad94f09275b8fd186a1c1b6a71fed/components/ntp_tiles/switches.h
[modify] https://crrev.com/d246e1f498fad94f09275b8fd186a1c1b6a71fed/testing/variations/fieldtrial_testing_config.json

Thanks for trace and revert. I will have another look.

 Issue 808368  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0

commit f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Wed Feb 14 10:10:10 2018

Remove influence of group name on NTPPopularSites studies

Recently, a misnamed study (see deleted test config) caused the feature
to fall back to the default popular sites. This isn't a big problem but
when it was finally named correctly, the names of the groups disabled
all popular sites.

Popular sites should not be so easy to disable. Therefore, remove the
group name condition.

Aforced cmd line flag should cover all possible cases and make the
intention very clear. This is already in place and remains untouched.

This change removes the deprecated and unused function for Demo users
on the Java side. This is necessary as the JNI calls would break the
tests otherwise (see linked  bug 808260 ).

Bug: 794329,  808260 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I92b9d7426095b4aba1c81450b052090afe69307d
Reviewed-on: https://chromium-review.googlesource.com/913574
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536691}
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/chrome/android/BUILD.gn
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/chrome/browser/about_flags.cc
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/components/ntp_tiles/BUILD.gn
[delete] https://crrev.com/fd0ce34715263d9068fb2357c43792661e5e0496/components/ntp_tiles/android/BUILD.gn
[delete] https://crrev.com/fd0ce34715263d9068fb2357c43792661e5e0496/components/ntp_tiles/android/java/src/org/chromium/components/ntptiles/MostVisitedSites.java
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/components/ntp_tiles/constants.cc
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/components/ntp_tiles/constants.h
[delete] https://crrev.com/fd0ce34715263d9068fb2357c43792661e5e0496/components/ntp_tiles/field_trial.cc
[delete] https://crrev.com/fd0ce34715263d9068fb2357c43792661e5e0496/components/ntp_tiles/field_trial.h
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/components/ntp_tiles/most_visited_sites.cc
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/components/ntp_tiles/most_visited_sites_unittest.cc
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/components/ntp_tiles/popular_sites_impl.cc
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/components/ntp_tiles/popular_sites_impl_unittest.cc
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/components/ntp_tiles/switches.cc
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/components/ntp_tiles/switches.h
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
[modify] https://crrev.com/f738ab9fcf17f3a94898d10aa0d9bf38f671ddf0/testing/variations/fieldtrial_testing_config.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a888982c8bda7f1c0a21cecd1a3401a1e0bef7a

commit 8a888982c8bda7f1c0a21cecd1a3401a1e0bef7a
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Wed Feb 14 12:44:41 2018

Remove category title when searching passwords

The title of the (only displayed) category causes confusion with
Talkback because it was counted as search result entry.
As it also doesn't need to be shown according to the latest
mocks, removing it should be just fine.

Bug:  808260 
Change-Id: I870bb02f9f936dbf4f41ad3edb9cf1b9f0617dec
Reviewed-on: https://chromium-review.googlesource.com/918621
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536701}
[modify] https://crrev.com/8a888982c8bda7f1c0a21cecd1a3401a1e0bef7a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java

(The CL in #7 belongs to the completely unrelated issue 810279 - just ignore it.)