There have been a couple instances where experiments or ANGLE changes have broken WebVR on Windows. At this point, I don't expect to be broken again, but we should have tests to ensure that is the case.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3 commit b81078b3f2226ba3bc2ece390bef3c2c2110bbd3 Author: Bill Orr <billorr@chromium.org> Date: Wed Mar 21 23:26:57 2018 Add a basic pixel test for submitted VR frames on Windows. This test stores a single pixels value in a file, then reads from the file. BUG= 808232 Change-Id: I2573a1f98188d232f25ff2ceb11cc15e67cc768f Reviewed-on: https://chromium-review.googlesource.com/963317 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#544902} [modify] https://crrev.com/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3/chrome/browser/vr/DEPS [add] https://crrev.com/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3/chrome/browser/vr/webvr_pixel_browser_test.cc [modify] https://crrev.com/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3/chrome/test/BUILD.gn [add] https://crrev.com/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3/chrome/test/data/vr/e2e_test_files/html/test_webvr_pixels.html [modify] https://crrev.com/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3/chrome/test/data/vr/e2e_test_files/resources/webvr_boilerplate.js [modify] https://crrev.com/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3/device/vr/BUILD.gn [modify] https://crrev.com/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3/device/vr/openvr/test/fake_openvr_impl_api.cc [add] https://crrev.com/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3/device/vr/openvr/test/fake_openvr_log.h [modify] https://crrev.com/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/b81078b3f2226ba3bc2ece390bef3c2c2110bbd3/testing/buildbot/chromium.gpu.json
Basic test is in.
Comment 1 by ddorwin@chromium.org
, Feb 1 2018Labels: M-67 VR-Desktop