New issue
Advanced search Search tips

Issue 808222 link

Starred by 1 user
Status: Fixed
Owner:
vmp...@chromium.org
Closed: Feb 2018
Cc:
chrishtr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add UKM aggregator for paint/layout metrics

Project Member Reported by vmp...@chromium.org, Feb 1 2018 
In order to record UKMs, we need to aggregate them locally since every event adds an entry in UKMs, which can result in a lot of data.

We need to add some sort of an aggregator and only push through the results at predefined intervals (like navigation).
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c6e0f7a6a499fc43daf449eb9333d25977280b9

commit 6c6e0f7a6a499fc43daf449eb9333d25977280b9
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Tue Feb 13 22:56:46 2018

[UKM] Add Blink.UpdateTimes UKM with local aggregation.

This patch aggregates local Blink.UpdateTimes and flushes every second
to actually record the metrics. It also flushes if the local frame view
is disposed and it had a timer (ie it was a local root).

R=chrishtr@chromium.org, wangxianzhu@chromium.org

Bug:  808222 , 783383
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9df3fd2fec9b2e837bc0a7c9023d16d208defa82
Reviewed-on: https://chromium-review.googlesource.com/905799
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536530}
[modify] https://crrev.com/6c6e0f7a6a499fc43daf449eb9333d25977280b9/services/metrics/public/cpp/ukm_recorder.h
[modify] https://crrev.com/6c6e0f7a6a499fc43daf449eb9333d25977280b9/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/6c6e0f7a6a499fc43daf449eb9333d25977280b9/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/6c6e0f7a6a499fc43daf449eb9333d25977280b9/third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/6c6e0f7a6a499fc43daf449eb9333d25977280b9/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/6c6e0f7a6a499fc43daf449eb9333d25977280b9/third_party/WebKit/Source/platform/DEPS
[add] https://crrev.com/6c6e0f7a6a499fc43daf449eb9333d25977280b9/third_party/WebKit/Source/platform/UkmTimeAggregator.cpp
[add] https://crrev.com/6c6e0f7a6a499fc43daf449eb9333d25977280b9/third_party/WebKit/Source/platform/UkmTimeAggregator.h
[add] https://crrev.com/6c6e0f7a6a499fc43daf449eb9333d25977280b9/third_party/WebKit/Source/platform/UkmTimeAggregatorTest.cpp
[modify] https://crrev.com/6c6e0f7a6a499fc43daf449eb9333d25977280b9/tools/metrics/ukm/ukm.xml

Comment 2 by vmp...@chromium.org, Feb 13 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment