Make all printing tests pass.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4809cce0a9e257ecea44b9fae51daca55c539468 commit 4809cce0a9e257ecea44b9fae51daca55c539468 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Feb 02 04:40:39 2018 [SPv175] Fix printing of subframe and when the frame is scrolled Set correct property tree state for frame printing. Skips frame scroll translation because we always print from the origin of the frame which initiated printing. We don't need to skip LayoutView scroll translation with RLS because we print in the LayoutView's container space. Bug: 808219 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7d605b7f5e79156829ba861a0a27b8c844892157 Reviewed-on: https://chromium-review.googlesource.com/894486 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533950} [modify] https://crrev.com/4809cce0a9e257ecea44b9fae51daca55c539468/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v175 [modify] https://crrev.com/4809cce0a9e257ecea44b9fae51daca55c539468/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp [modify] https://crrev.com/4809cce0a9e257ecea44b9fae51daca55c539468/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbb84fced88e2f006476be4498fd77f2fa7fb252 commit dbb84fced88e2f006476be4498fd77f2fa7fb252 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Sat Feb 03 00:33:35 2018 [CI] Test subframe printing Previously subframe printing was not testable in layout tests. We had to create ManualTests to test subframe printing, but it's hard to maintain. Add testRunner.setPrintingForFrame(frame_name) to allow testing subframe printing. This won't automate testing of anchor printing though, because location of anchor is invisible. That still requires viewing the generated pdf file. R=dmazzoni,bokan TBR=dmazzoni@chromium.org (already lgtm'ed) Test: printing/print-subframe.html Bug: 808219 Change-Id: I1f927c5ea500a6da8fe558139433b7d548bc2e2e Reviewed-on: https://chromium-review.googlesource.com/898244 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534210} [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/content/shell/test_runner/layout_test_runtime_flags.cc [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/content/shell/test_runner/layout_test_runtime_flags.h [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/content/shell/test_runner/pixel_dump.cc [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/content/shell/test_runner/test_runner.cc [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/content/shell/test_runner/test_runner.h [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/printing/absolute-position-headers-and-footers-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-but-static-headers-and-footers-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-clipped-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-inside-transform-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/printing/tfoot-repeats-at-bottom-of-each-page-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/printing/tfoot-repeats-at-bottom-of-each-page-multiple-tables-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/printing/thead-repeats-at-top-of-each-page-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.png [add] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/linux/virtual/spv175/printing/fixed-positioned-headers-and-footers-clipped-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/mac/printing/absolute-position-headers-and-footers-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-but-static-headers-and-footers-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-clipped-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-inside-transform-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/mac/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/mac/printing/tfoot-repeats-at-bottom-of-each-page-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/mac/printing/tfoot-repeats-at-bottom-of-each-page-multiple-tables-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/mac/printing/thead-repeats-at-top-of-each-page-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/mac/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/win/printing/fixed-positioned-headers-and-footers-absolute-covering-some-pages-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/win/printing/tfoot-repeats-at-bottom-of-each-page-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/win/printing/tfoot-repeats-at-bottom-of-each-page-multiple-tables-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/win/printing/thead-repeats-at-top-of-each-page-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/win/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.png [add] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/win7/printing/absolute-position-headers-and-footers-expected.png [add] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/win7/printing/fixed-positioned-but-static-headers-and-footers-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/win7/printing/fixed-positioned-headers-and-footers-clipped-expected.png [add] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/win7/printing/fixed-positioned-headers-and-footers-expected.png [add] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/win7/printing/fixed-positioned-headers-and-footers-inside-transform-expected.png [add] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/platform/win7/printing/fixed-positioned-headers-and-footers-larger-than-page-expected.png [add] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/printing/print-subframe-expected.html [add] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/printing/print-subframe.html [delete] https://crrev.com/66958462e684149bcb220000868e8247096e435b/third_party/WebKit/LayoutTests/virtual/spv175/printing/fixed-positioned-headers-and-footers-clipped-expected.png [delete] https://crrev.com/66958462e684149bcb220000868e8247096e435b/third_party/WebKit/LayoutTests/virtual/spv175/printing/fixed-positioned-headers-and-footers-clipped-expected.txt [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/LayoutTests/virtual/spv175/printing/thead-under-multicol-expected.png [modify] https://crrev.com/dbb84fced88e2f006476be4498fd77f2fa7fb252/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
Comment 1 by bugdroid1@chromium.org
, Feb 2 2018