New issue
Advanced search Search tips

Issue 808210 link

Starred by 2 users
Status: Fixed
Owner:
ricardoq@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

copy-to-clipboard to support HTML format in addition to Image

Project Member Reported by ricardoq@chromium.org, Feb 1 2018 
In copy-to-clipboard, add 'image embedded in HTML' format in addition to Image format.

In this CL: https://chromium.googlesource.com/chromium/src/+/a6e33d4ee1539449f56053ce8523c338d247bff2
WriteHTML() was replaced with WriteImage() in order to support Hangouts and other extensions.

But ARC++ relies on the HTML mime type from the clipboard to copy images.
So, with that CL it is no longer possible to use the "copy to clipboard" feature to copy images from Chrome to ARC.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/205f7aff9eaa59f63a9a3baf7ae97b75e863fab5

commit 205f7aff9eaa59f63a9a3baf7ae97b75e863fab5
Author: Ricardo Quesada <ricardoq@google.com>
Date: Fri Feb 02 17:16:55 2018

Use WriteHTML for "Copy to clipboard" button

Use WriteHTML for "Copy to clipboard" button, in addition to WriteImage.
This is needed by ARC, which for the moment, only support HTML and plain
clips from the Clipboard. It cannot see SkBitmap clips.

This CL restores the code that was before this one:
https://chromium-review.googlesource.com/c/chromium/src/+/781342
while also preserving its functionality.

(and adds: #include <utility> required by std::move)

TEST=copy-to-clipboard works Ok with Hangouts extension and in ARC++.
BUG= 808210 

Change-Id: I1018d503dfd69d4677c1726c3abb4c0202697fcd
Reviewed-on: https://chromium-review.googlesource.com/898424
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Ricardo Quesada <ricardoq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534081}
[modify] https://crrev.com/205f7aff9eaa59f63a9a3baf7ae97b75e863fab5/chrome/browser/ui/ash/chrome_screenshot_grabber.cc

Comment 2 by ricardoq@chromium.org, Feb 2 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment