FaviconCache::page_favicon_map_ can grow beyond reasonable limits in some cases |
||||
Issue descriptionIf there is a URL redirect loop on a website, all the page_urls have the same icon_url. So, we end up having only one entry in the synced_favicons cache. But the page_favicon_map_ keeps growing indefinitely. Related issue 750845, 732969 .
,
Feb 19 2018
I don't follow where the problem is: A redirect loop means there's a finite set of URLs. page_favicon_map_ is an std::map, so it can have at most one entry per URL. How can it grow indefinitely? I feel like I'm missing something :) Could you provide more details on what exactly the problem is, or maybe repro steps? Thanks!
,
Feb 20 2018
Ah you're right, I guess it was not redirect loop, but just a lot of redirects then. I do not have repro steps, I have just observed reports from users with stack traces allocating like 4-5MB memory at FaviconCache::OnFaviconVisited() and the only way that could grow is if the icon_url is same and page_url is different. If the icon_url were different then we have a maximum of 200 favicons stored in sync and beyond that the map is cleared.
,
Feb 22 2018
Okay, I guess adding some limit on the maximum number of entries is the only option then? |
||||
►
Sign in to add a comment |
||||
Comment 1 by pav...@chromium.org
, Feb 2 2018Owner: ----