New issue
Advanced search Search tips

Issue 808182 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 739532



Sign in to add a comment

Polymer WebUI: Update cr-action-menu to conform to hybrid mode.

Project Member Reported by dpa...@chromium.org, Feb 1 2018

Issue description

cr-action-menu currently uses <content> and ::content. Need to update it to <slot> and ::slotted(), as well as all of its usages.


[1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html
 
Blocking: 739532
Status: Started (was: Assigned)
CL at https://chromium-review.googlesource.com/c/chromium/src/+/898403.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c69754281d9862212a7957ee367812dcb52bfb18

commit c69754281d9862212a7957ee367812dcb52bfb18
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 02 02:14:07 2018

WebUI: Migrate cr-action-menu to Polymer's hybrid mode.

Bug:  808182 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I02f96d49f3dffcde80f0bca06d1d588d080c743f
Reviewed-on: https://chromium-review.googlesource.com/898403
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533917}
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/chrome/test/data/webui/cr_elements/cr_action_menu_test.js
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/ui/webui/resources/cr_components/certificate_manager/certificate_subentry.html
[modify] https://crrev.com/c69754281d9862212a7957ee367812dcb52bfb18/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da4c91111d834681bd5b9603a94a8f8d6dd9f215

commit da4c91111d834681bd5b9603a94a8f8d6dd9f215
Author: dpapad <dpapad@chromium.org>
Date: Tue Feb 06 00:43:01 2018

History UI: Fix synced tabs cr-action-menu.

It was missed in r533917.

Bug:  808182 , 808943 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3e6774385b6fe2484f7f92042e2442e4bf1e6267
Reviewed-on: https://chromium-review.googlesource.com/902771
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534559}
[modify] https://crrev.com/da4c91111d834681bd5b9603a94a8f8d6dd9f215/chrome/browser/resources/md_history/synced_device_manager.html

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c69778aabd2cdc75008d2dcefa5e35b8ba7783e

commit 4c69778aabd2cdc75008d2dcefa5e35b8ba7783e
Author: dpapad <dpapad@chromium.org>
Date: Tue Feb 06 23:08:36 2018

Downloads UI: Fix "clear all" cr-action-menu entry.

It was missed in r533917.

Bug:  809381 , 808182 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4b7d574e2a1f6b3522547def1b2c6615e974143a
Reviewed-on: https://chromium-review.googlesource.com/904851
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534824}
[modify] https://crrev.com/4c69778aabd2cdc75008d2dcefa5e35b8ba7783e/chrome/browser/resources/md_downloads/toolbar.html

Status: Fixed (was: Started)
I believe this is fixed now.

Sign in to add a comment