New issue
Advanced search Search tips

Issue 808159 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: console filters should indicate when filter is applied

Project Member Reported by l...@chromium.org, Feb 1 2018

Issue description

It's too easy to add a filter, forget about it, and not realize that items are being hidden.

Potential UX approaches:
- red/colored highlight on the console filter input field
- levels dropdown could change background to red/colored when not default
 
Independent report of a user going through this same issue:

https://twitter.com/joaocunha/status/964625099851739137
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3078ce545f4c4ea7b39d3b3466f12ea330c6e6d8

commit 3078ce545f4c4ea7b39d3b3466f12ea330c6e6d8
Author: Erik Luo <luoe@chromium.org>
Date: Mon Jul 02 19:32:06 2018

DevTools: give visual signal when filters are active

- Non-empty text filters retain their blue outline even when not
  focused.
- Searching the the StylesSidebarPane no longer highlights the
  toolbar yellow, just the selector/prop matches.

Screenshots:
https://imgur.com/a/suybNVy
https://imgur.com/a/s0R04ar

Bug:  808159 
Change-Id: I7dc5b89ca96ca181e767bd271cd648bee4cb0ca1
Reviewed-on: https://chromium-review.googlesource.com/1060574
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571967}
[modify] https://crrev.com/3078ce545f4c4ea7b39d3b3466f12ea330c6e6d8/third_party/blink/renderer/devtools/front_end/elements/ComputedStyleWidget.js
[modify] https://crrev.com/3078ce545f4c4ea7b39d3b3466f12ea330c6e6d8/third_party/blink/renderer/devtools/front_end/elements/StylesSidebarPane.js
[modify] https://crrev.com/3078ce545f4c4ea7b39d3b3466f12ea330c6e6d8/third_party/blink/renderer/devtools/front_end/elements/computedStyleSidebarPane.css
[modify] https://crrev.com/3078ce545f4c4ea7b39d3b3466f12ea330c6e6d8/third_party/blink/renderer/devtools/front_end/elements/stylesSidebarPane.css
[modify] https://crrev.com/3078ce545f4c4ea7b39d3b3466f12ea330c6e6d8/third_party/blink/renderer/devtools/front_end/ui/filter.css
[modify] https://crrev.com/3078ce545f4c4ea7b39d3b3466f12ea330c6e6d8/third_party/blink/renderer/devtools/front_end/ui/toolbar.css

Status: Fixed (was: Assigned)

Sign in to add a comment