New issue
Advanced search Search tips

Issue 808158 link

Starred by 1 user
Status: Fixed
Owner:
jamescook@chromium.org
Closed: Feb 2018
Cc:
sky@chromium.org
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add a shelf indicator for --mash mode

Project Member Reported by jamescook@chromium.org, Feb 1 2018 
--mash causes hundreds of thousands of lines of UI code to behave differently, but in the best case there's no visual indication of what mode you're in.

Add an indicator to the status area that shows if you are in one of these modes.

We could add this for --mus too, but that would need to be limited based on developer builds and/or release channels, since if we roll out --mus with a Finch trial we don't want to show the indicator.

Once we build a Chrome OS "safe boot mode" this would also be a place to show that string, similar to how MS Windows does this.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/411345b26edd6b0603824622c9cac20a3a326514

commit 411345b26edd6b0603824622c9cac20a3a326514
Author: James Cook <jamescook@chromium.org>
Date: Wed Feb 07 01:11:52 2018

cros: Add a status area indicator when running with --mash

--mash causes thousands of lines of UI code to behave differently, but
in the best case there's no visual indication of what mode you're in.

Add an indicator to the status area that shows if you're running --mash.
This could be generalized later to a "flag warning", like we use in
browser windows when running --no-sandbox.

Bug:  808158 
Test: ash_unittests
Change-Id: I477158085bed9665c2fc9e7d2356c1f346083919
Reviewed-on: https://chromium-review.googlesource.com/905631
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534860}
[modify] https://crrev.com/411345b26edd6b0603824622c9cac20a3a326514/ash/BUILD.gn
[add] https://crrev.com/411345b26edd6b0603824622c9cac20a3a326514/ash/system/flag_warning/flag_warning_tray.cc
[add] https://crrev.com/411345b26edd6b0603824622c9cac20a3a326514/ash/system/flag_warning/flag_warning_tray.h
[add] https://crrev.com/411345b26edd6b0603824622c9cac20a3a326514/ash/system/flag_warning/flag_warning_tray_unittest.cc
[modify] https://crrev.com/411345b26edd6b0603824622c9cac20a3a326514/ash/system/session/logout_button_tray.h
[modify] https://crrev.com/411345b26edd6b0603824622c9cac20a3a326514/ash/system/status_area_widget.cc
[modify] https://crrev.com/411345b26edd6b0603824622c9cac20a3a326514/ash/system/status_area_widget.h

Comment 2 by jamescook@chromium.org, Feb 7 2018

Status: Fixed (was: Started)
Done. See screenshot.
mash-indicator.png
48.1 KB View Download
►

Sign in to add a comment