New issue
Advanced search Search tips

Issue 808154 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Substitute sequence number in latency info

Project Member Reported by nzolghadr@chromium.org, Feb 1 2018

Issue description

As one of the steps towards latency info v2 we need to clean up data per component. sequence number variable seems a reasonable start.
 

Comment 1 by kbr@chromium.org, Mar 7 2018

Cc: sadrul@chromium.org
Please link this bug to some parent bug describing the overall rearchitecture. Thanks.

Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5870ee11dd77472290d43bf85ce7d35258f70165

commit 5870ee11dd77472290d43bf85ce7d35258f70165
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Fri May 18 19:08:30 2018

Remove sequence number from LatencyInfo

There is one instance that sequence number was
useful and it was in synchronizing the snapshots.
For that this CL adds a plain field to LatencyInfo.

Bug:  808154 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I29e5dabca7b2db5da0d548a7dce3be65c8d913ae
Reviewed-on: https://chromium-review.googlesource.com/902762
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559980}
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/cc/trees/latency_info_swap_promise.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/cc/trees/latency_info_swap_promise_monitor.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/cc/trees/proxy_main.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/cc/trees/single_thread_proxy.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/components/viz/service/display/display.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/components/viz/service/display/output_surface.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/components/viz/service/display_embedder/software_output_surface.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/browser/compositor/software_browser_compositor_output_surface.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/browser/renderer_host/input/synthetic_gesture_target_base.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/browser/renderer_host/render_widget_host_view_cocoa.mm
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/common/input/event_with_latency_info_unittest.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/events/event.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/latency/ipc/latency_info_param_traits.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/latency/ipc/latency_info_param_traits_macros.h
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/latency/ipc/latency_info_param_traits_unittest.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/latency/latency_info.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/latency/latency_info.h
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/latency/latency_info_unittest.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/latency/mojo/latency_info.mojom
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/latency/mojo/latency_info_struct_traits.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/latency/mojo/latency_info_struct_traits.h
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/latency/mojo/struct_traits_unittest.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/views/win/hwnd_message_handler.cc
[modify] https://crrev.com/5870ee11dd77472290d43bf85ce7d35258f70165/ui/views/win/pen_event_processor.cc

Status: Fixed (was: Started)

Sign in to add a comment