New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808149 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 805543



Sign in to add a comment

Swarming URL changes related to Cloud Endpoint deprication.

Project Member Reported by dgarr...@chromium.org, Feb 1 2018

Issue description

We keep getting emails about "[Reminder] Cloud Endpoints Frameworks v1 is deprecated as of August 2, 2017" for the project "ChromeOS Proxy (chromeos-proxy)"

If we do nothing before the deprication is hit, we will lose access to the lab from builders.

From maruel@:


> Yep!  https://crbug.com/805543 
> 
> We're looking at the options right now, if you use the /api/ URLs
> instead of /_ah/api/, you are already not using endpoints v1.


So... we need to update the URLs in whatever scripts we have that make calls to the swarming proxy. xixuan@, shuqianz@ suggested that you are the best owner for this.

 
Cc: nxia@chromium.org dgarr...@chromium.org
Re #0, I don't think our builder currently use API to connect to chromeos-proxy service:

https://cs.corp.google.com/chromeos_public/chromite/cbuildbot/swarming_lib.py?q=swarming_lib.py&sq=package:%5Echromeos_(internal%7Cpublic)$&l=22


But we do use this API for suite-scheduler now:

https://cs.corp.google.com/chromeos_public/infra/suite_scheduler/swarming_lib.py?q=swarming_&sq=package:%5Echromeos_(internal%7Cpublic)$&l=98


BTW, in searching, I found we use Endpoint v1 for buildbucket:

https://cs.corp.google.com/search/?q=_ah/api/&sq=package:%5Echromeos_(internal%7Cpublic)$&type=cs

Is this a problem?






swarming client:
We may need to update our copy of the third part swarming client. maruel@ can advise what version to update to use. We probably need to test that, because we haven't updated since 2014 and client behaviors may have changed some.

That can be done here:

https://cs.corp.google.com/chromeos_public/manifest/full.xml?rcl=d201f188b1e056e45d999b00a1b7691e7ca6e946&l=52

suite_scheduler:
Good catch. It looks like that's a simple change to make.

buildbucket:
Very good catch. We probably do need to update it, but need to make sure that the alternative URL is ready.
Blockedon: 805543
you can take whatever client.git that happens to be used by src.git:
https://cs.chromium.org/chromium/src/DEPS?q=deps&sq=package:chromium&l=90
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS
Cc: jclinton@chromium.org
Per the blocked bug, webapp2 is available bBuildbucket and we have a fix above for Swarming. So, who's working on this?
Project Member

Comment 8 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3e84059133fa7470286fe3b78ac263ffde902e68

commit 3e84059133fa7470286fe3b78ac263ffde902e68
Author: Xixuan Wu <xixuan@chromium.org>
Date: Wed May 30 23:12:01 2018

upload_symbols: Fix api calls changed by swarming.client upgrade.

BUG= chromium:808149 
TEST=Ran unittest.

Change-Id: I1fa02282044d919634e55fe30831c1fd12ada49a
Reviewed-on: https://chromium-review.googlesource.com/1079720
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/3e84059133fa7470286fe3b78ac263ffde902e68/scripts/upload_symbols_unittest.py
[modify] https://crrev.com/3e84059133fa7470286fe3b78ac263ffde902e68/scripts/upload_symbols.py

Project Member

Comment 9 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/16d30e8aa67120f115aed44ecd6b5d1c92aca3a4

commit 16d30e8aa67120f115aed44ecd6b5d1c92aca3a4
Author: Xixuan Wu <xixuan@chromium.org>
Date: Wed May 30 23:12:11 2018

manifest: upgrade swarming.client to new version.

Upgrade it to 3543e21830b9549e5b70c8c49482c8c28da2ba9.

BUG= chromium:808149 ,  chromium:845314 
TEST=Ran tryjob.
CQ-DEPEND=CL:*632550

Change-Id: I9f58594e6d34527a0246f4b8f311859cbf1ab1f7
Reviewed-on: https://chromium-review.googlesource.com/1077192
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/16d30e8aa67120f115aed44ecd6b5d1c92aca3a4/full.xml

Project Member

Comment 10 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/2d5dd72afbf7e8496aa2e2f79e26e22eaa64046a

commit 2d5dd72afbf7e8496aa2e2f79e26e22eaa64046a
Author: Xixuan Wu <xixuan@chromium.org>
Date: Wed May 30 23:12:22 2018

Project Member

Comment 11 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad1a7be150bfdce47f4967f32cd8130418102a29

commit ad1a7be150bfdce47f4967f32cd8130418102a29
Author: chromite-chromium-autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 31 14:38:38 2018

Roll src/third_party/chromite a05ffcc..8100779 (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a05ffcc..8100779


git log a05ffcc..8100779 --date=short --no-merges --format='%ad %ae %s'
2018-05-16 achuith@chromium.org cros_build_lib: Support for streaming output.
2018-05-30 xixuan@chromium.org upload_symbols: Fix api calls changed by swarming.client upgrade.

Created with:
  gclient setdep -r src/third_party/chromite@8100779

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:829481 , chromium:808149 

TBR=chrome-os-gardeners@chromium.org

Change-Id: I500767e4f46b125265cf5dfcb9366b548520a7ef
Reviewed-on: https://chromium-review.googlesource.com/1080453
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563224}
[modify] https://crrev.com/ad1a7be150bfdce47f4967f32cd8130418102a29/DEPS

Comment 12 by nxia@chromium.org, Jun 8 2018

Cc: -nxia@chromium.org
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Cc: -jkop@chromium.org xixuan@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
modus podens > modus tollens
Status: Fixed (was: Untriaged)
I think that smut@ fixed these in bulk.

Sign in to add a comment