New issue
Advanced search Search tips

Issue 808138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 177475



Sign in to add a comment

Enable -Wimplicit-fallthrough warning in Fuchsia builds

Project Member Reported by w...@chromium.org, Feb 1 2018

Issue description

This ensures that fall-through switch case statements require explicit FALLTHROUGH annotation, otherwise a warning is triggered.
 

Comment 1 by w...@chromium.org, Feb 1 2018

Blocking: 177475
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d77827f4e2517e5ed7a39d2668bc051de10ac6a

commit 0d77827f4e2517e5ed7a39d2668bc051de10ac6a
Author: Wez <wez@chromium.org>
Date: Fri Feb 02 03:10:57 2018

Enable -Wimplicit-fallthrough on all Fuchsia builds.

Unlike the existing Linux warnings, this is enabled for Fuchsia
including Chromecast and Ozone builds.

Bug:  177475 ,  808138 
Change-Id: Idaf85eabbf3029f37c9c37c7b1bd8f03e411a9d1
Reviewed-on: https://chromium-review.googlesource.com/898007
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533940}
[modify] https://crrev.com/0d77827f4e2517e5ed7a39d2668bc051de10ac6a/build/config/compiler/BUILD.gn

Comment 3 by w...@chromium.org, Feb 2 2018

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9422fcf0e314b68aa06e68ac4727e9ecd5b0a2f

commit e9422fcf0e314b68aa06e68ac4727e9ecd5b0a2f
Author: Yuta Kitamura <yutak@chromium.org>
Date: Fri Feb 02 04:19:32 2018

Add FALLTHROUGH to fix a compile error.

TBR=wez@chromium.org

Bug:  808138 
Change-Id: I773d3238fb4140211cba071148d1c864930983c9
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/897393
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533948}
[modify] https://crrev.com/e9422fcf0e314b68aa06e68ac4727e9ecd5b0a2f/chromecast/media/cma/backend/stream_mixer.cc

Sign in to add a comment