New issue
Advanced search Search tips

Issue 808136 link

Starred by 1 user
Status: Fixed
Owner:
lazyboy@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Replace ExtensionRegistryObserver subclass w/ TestExtensionRegistryObserver in content_verifier_browsertest

Project Member Reported by lazyboy@chromium.org, Feb 1 2018 
This came up during review:

https://chromium-review.googlesource.com/c/chromium/src/+/894373/3/chrome/browser/extensions/content_verifier_browsertest.cc#590

TestExtensionRegistryObserver has a handful of method that already provides similar functionality.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9308190400431e8c908f693910bc8058871ddd1e

commit 9308190400431e8c908f693910bc8058871ddd1e
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Fri Feb 02 05:36:29 2018

Use TestExtensionRegistryObserver in two test files.

These tests extend ExtensionRegistryObserver to wait for extension
load/unload etc. TestExtensionRegistryObserver already provides
this functionality.

Bug:  808136 
Test: None
Change-Id: I195f206163f54b7547079b10c48e677a86eaf6db
Reviewed-on: https://chromium-review.googlesource.com/897468
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533967}
[modify] https://crrev.com/9308190400431e8c908f693910bc8058871ddd1e/chrome/browser/autocomplete/keyword_extensions_delegate_impl_unittest.cc
[modify] https://crrev.com/9308190400431e8c908f693910bc8058871ddd1e/chrome/browser/extensions/content_verifier_browsertest.cc
[modify] https://crrev.com/9308190400431e8c908f693910bc8058871ddd1e/extensions/browser/test_extension_registry_observer.cc
[modify] https://crrev.com/9308190400431e8c908f693910bc8058871ddd1e/extensions/browser/test_extension_registry_observer.h

Comment 2 by lazyboy@chromium.org, Feb 2 2018

Status: Fixed (was: Started)
►

Sign in to add a comment