Prevent notification for posting of Tricium robot comments |
||
Issue descriptionIt turns out that the ReviewInput in Gerrit API includes an optional field "notify", which can be set to "NONE", indicating that emails shouldn't be sent out. I think we can just change Tricium to add this to all requests to Gerrit. Should be a small change. The advantage of doing this would be that it would reduce the spam/noise from Tricium, since we want it to be as unobtrusive as possible. https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#review-input
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/afaeeb0fc4a4b8d4decf639fde5fd8aae17f54a2 commit afaeeb0fc4a4b8d4decf639fde5fd8aae17f54a2 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Feb 01 22:08:08 2018 [Tricium] Include notify: NONE when posting to Gerrit Bug: 808122 Change-Id: I421074fe62882d68061eef26f0a0643bf0a76c2a Reviewed-on: https://chromium-review.googlesource.com/898037 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/afaeeb0fc4a4b8d4decf639fde5fd8aae17f54a2/go/src/infra/tricium/appengine/gerrit/gerrit.go
,
Feb 2 2018
Re #1: Good point! Filed bug 808555 . This bug now has a submitted fix CL but is not yet verified as of today. |
||
►
Sign in to add a comment |
||
Comment 1 by aga...@chromium.org
, Feb 1 2018