and GpuDataManagerImpl and GpuDataManagerImplPrivate now that we move GPU info collection and blacklist and driver bug workarounds decisions to GPU process
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5788a1b9e936ed523f8390eaa62a06a7b073bd7e commit 5788a1b9e936ed523f8390eaa62a06a7b073bd7e Author: Zhenyao Mo <zmo@chromium.org> Date: Fri Feb 09 20:23:48 2018 Remove dead code related with ContentGpuClient and GL strings. Now we collect GPUInfo on GPU startup, we always initialize GL bindings, create a GL contetx, and collect the GL strings. No need for specific mechanism on ChromeCAST. BUG= 744658 , 808119 TEST=bots R=halliwell@chromium.org,piman@chromium.org Change-Id: I23183baa03349e6fa3ce9d6598cbed426bd160a8 Reviewed-on: https://chromium-review.googlesource.com/907860 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#535807} [modify] https://crrev.com/5788a1b9e936ed523f8390eaa62a06a7b073bd7e/chromecast/app/BUILD.gn [modify] https://crrev.com/5788a1b9e936ed523f8390eaa62a06a7b073bd7e/chromecast/app/DEPS [modify] https://crrev.com/5788a1b9e936ed523f8390eaa62a06a7b073bd7e/chromecast/app/cast_main_delegate.cc [modify] https://crrev.com/5788a1b9e936ed523f8390eaa62a06a7b073bd7e/chromecast/app/cast_main_delegate.h [delete] https://crrev.com/84780aff9daa47f8f18a9d9efd7c4e70590384f0/chromecast/gpu/BUILD.gn [delete] https://crrev.com/84780aff9daa47f8f18a9d9efd7c4e70590384f0/chromecast/gpu/DEPS [delete] https://crrev.com/84780aff9daa47f8f18a9d9efd7c4e70590384f0/chromecast/gpu/cast_content_gpu_client.cc [delete] https://crrev.com/84780aff9daa47f8f18a9d9efd7c4e70590384f0/chromecast/gpu/cast_content_gpu_client.h [modify] https://crrev.com/5788a1b9e936ed523f8390eaa62a06a7b073bd7e/chromecast/public/cast_sys_info.h [modify] https://crrev.com/5788a1b9e936ed523f8390eaa62a06a7b073bd7e/content/public/gpu/content_gpu_client.cc [modify] https://crrev.com/5788a1b9e936ed523f8390eaa62a06a7b073bd7e/content/public/gpu/content_gpu_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d2ca7044fa9dfdd06a5df8fddcbdc7d69c5683e commit 2d2ca7044fa9dfdd06a5df8fddcbdc7d69c5683e Author: Zhenyao Mo <zmo@chromium.org> Date: Fri Feb 09 20:42:45 2018 Further clean up GpuDataManager{Impl}{Private}. Now we no longer do a bunch of heavy ops (like collect GPUInfo, etc) in Initialize(), we can simply merge it into constructor and that enables some simplification. BUG= 808119 TEST=bots R=kbr@chromium.org,piman@chromium.org Change-Id: I696a146221ef32319a14294a0193c1659703295d Reviewed-on: https://chromium-review.googlesource.com/910044 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#535816} [modify] https://crrev.com/2d2ca7044fa9dfdd06a5df8fddcbdc7d69c5683e/content/browser/browser_main_loop.cc [modify] https://crrev.com/2d2ca7044fa9dfdd06a5df8fddcbdc7d69c5683e/content/browser/gpu/gpu_data_manager_impl.cc [modify] https://crrev.com/2d2ca7044fa9dfdd06a5df8fddcbdc7d69c5683e/content/browser/gpu/gpu_data_manager_impl.h [modify] https://crrev.com/2d2ca7044fa9dfdd06a5df8fddcbdc7d69c5683e/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/2d2ca7044fa9dfdd06a5df8fddcbdc7d69c5683e/content/browser/gpu/gpu_data_manager_impl_private.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9307be37d14f846ea9c9df07ac8cc9079c8201c1 commit 9307be37d14f846ea9c9df07ac8cc9079c8201c1 Author: Zhenyao Mo <zmo@chromium.org> Date: Fri Feb 23 00:23:01 2018 Remove info collection states from GPUInfo. They are really a messy design. By returning a bool at various collector function seems enough. BUG= 808119 TEST=bots R=piman@chromium.org,kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I42dd69587d70d04930c81fdf9cfb727527e59ed6 Reviewed-on: https://chromium-review.googlesource.com/924699 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#538636} [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/components/viz/service/gl/gpu_service_impl.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/content/browser/gpu/gpu_data_manager_impl_private.h [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_info.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_info.h [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_info_collector.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_info_collector.h [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_info_collector_android.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_info_collector_fuchsia.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_info_collector_linux.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_info_collector_mac.mm [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_info_collector_unittest.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_info_collector_win.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_info_unittest.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/config/gpu_test_config.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/ipc/common/gpu_info.mojom [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/ipc/common/gpu_info_struct_traits.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/ipc/common/gpu_info_struct_traits.h [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/ipc/common/struct_traits_unittest.cc [modify] https://crrev.com/9307be37d14f846ea9c9df07ac8cc9079c8201c1/gpu/ipc/service/gpu_init.cc
Closing this bug as I don't plan to do further cleanup on this any time soon.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4be07e7fe7b5f82cb45f0a25eb458f4e66b234b2 commit 4be07e7fe7b5f82cb45f0a25eb458f4e66b234b2 Author: Zhenyao Mo <zmo@chromium.org> Date: Wed Feb 28 01:17:25 2018 Simplify Win GPU histogram code a little bit. So we don't have to update this code everytime we support a new Windows version. BUG= 808119 TEST=bots R=kbr@chromium.org Change-Id: I1ab720387584027303b87a96d2c5350204603f5e Reviewed-on: https://chromium-review.googlesource.com/924523 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#539615} [modify] https://crrev.com/4be07e7fe7b5f82cb45f0a25eb458f4e66b234b2/base/win/windows_version.h [modify] https://crrev.com/4be07e7fe7b5f82cb45f0a25eb458f4e66b234b2/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/4be07e7fe7b5f82cb45f0a25eb458f4e66b234b2/tools/metrics/histograms/enums.xml [modify] https://crrev.com/4be07e7fe7b5f82cb45f0a25eb458f4e66b234b2/tools/metrics/histograms/histograms.xml
Comment 1 by zmo@chromium.org
, Feb 1 2018Blocking: 683226
Labels: -Pri-3 Pri-2