New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808089 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 831925



Sign in to add a comment

Report First Input Delay across OOPIFs

Project Member Reported by tdres...@chromium.org, Feb 1 2018

Issue description

Currently we only report First Input Delay in the process of the main document. We should report it across OOPIFs too.

This will involve making the InteractiveDetector exist for OOPIFs, and adding some browser side merging code here:
PageLoadMetricsUpdateDispatcher::UpdateMetrics
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe64540e01311889d266c94de15b594e3e0f21cc

commit fe64540e01311889d266c94de15b594e3e0f21cc
Author: Tim Dresser <tdresser@chromium.org>
Date: Tue Feb 13 15:20:21 2018

Report First Input Delay across OOPIFs, report First Input Timestamp.

Previously we only reported for documents in the same process.

Adds InteractiveTiming.FirstInputTimestamp UKM,
PageLoad.InteractiveTiming.FirstInputTimestamp UMA.

Bug:  803935 ,  808089 
Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32
Reviewed-on: https://chromium-review.googlesource.com/901802
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536358}
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/loader/InteractiveDetectorTest.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/tools/metrics/ukm/ukm.xml

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f

commit 2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f
Author: Timothy Dresser <tdresser@chromium.org>
Date: Tue Feb 13 15:33:48 2018

Revert "Report First Input Delay across OOPIFs, report First Input Timestamp."

This reverts commit fe64540e01311889d266c94de15b594e3e0f21cc.

Reason for revert: Accidentally skipped CQ.

Original change's description:
> Report First Input Delay across OOPIFs, report First Input Timestamp.
> 
> Previously we only reported for documents in the same process.
> 
> Adds InteractiveTiming.FirstInputTimestamp UKM,
> PageLoad.InteractiveTiming.FirstInputTimestamp UMA.
> 
> Bug:  803935 ,  808089 
> Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32
> Reviewed-on: https://chromium-review.googlesource.com/901802
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536358}

TBR=isherman@chromium.org,tdresser@chromium.org,tsepez@chromium.org,dtapuska@chromium.org,bmcquade@chromium.org,dproy@chromium.org

Change-Id: I8cd3b5abf8972447092027cf46815d4b1e41fd02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  803935 ,  808089 
Reviewed-on: https://chromium-review.googlesource.com/916064
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536360}
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/loader/InteractiveDetectorTest.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/tools/metrics/ukm/ukm.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a10963705bce537dbe00ebdd6f07bde46dda8e3c

commit a10963705bce537dbe00ebdd6f07bde46dda8e3c
Author: Tim Dresser <tdresser@chromium.org>
Date: Wed Feb 14 14:35:14 2018

Reland "Report First Input Delay across OOPIFs, report First Input Timestamp."

This is a reland of fe64540e01311889d266c94de15b594e3e0f21cc.

Original change's description:
> Report First Input Delay across OOPIFs, report First Input Timestamp.
>
> Previously we only reported for documents in the same process.
>
> Adds InteractiveTiming.FirstInputTimestamp UKM,
> PageLoad.InteractiveTiming.FirstInputTimestamp UMA.
>
> Bug:  803935 ,  808089 
> Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32
> Reviewed-on: https://chromium-review.googlesource.com/901802
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536358}

Accidentally skipped CQ. Then reverted.

TBRing original reviews:

TBR=bmcquade@chromium.org, dtapuska@chromium.org, isherman@chromium.org, tsepez@chromium.org

Bug:  803935 ,  808089 
Change-Id: Ia4e47ea1fd4bc557a193b84e199dd9f3ddf1e6cb
Reviewed-on: https://chromium-review.googlesource.com/916007
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536712}
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/loader/InteractiveDetectorTest.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/tools/metrics/ukm/ukm.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 15 2018

Labels: merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fb61362b60d8c89aedf247484de1adb8e3a09b4

commit 8fb61362b60d8c89aedf247484de1adb8e3a09b4
Author: Tim Dresser <tdresser@chromium.org>
Date: Thu Feb 15 21:55:13 2018

Report First Input Delay across OOPIFs, report First Input Timestamp.

This is a cherry-pick of a reland.

This is a reland of fe64540e01311889d266c94de15b594e3e0f21cc.

Original change's description:
> Report First Input Delay across OOPIFs, report First Input Timestamp.
>
> Previously we only reported for documents in the same process.
>
> Adds InteractiveTiming.FirstInputTimestamp UKM,
> PageLoad.InteractiveTiming.FirstInputTimestamp UMA.
>
> Bug:  803935 ,  808089 
> Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32
> Reviewed-on: https://chromium-review.googlesource.com/901802
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536358}

Accidentally skipped CQ. Then reverted.

TBRing original reviews:

TBR=bmcquade@chromium.org, dtapuska@chromium.org, isherman@chromium.org, tsepez@chromium.org

(cherry picked from commit a10963705bce537dbe00ebdd6f07bde46dda8e3c)

Bug:  803935 ,  808089 
Change-Id: Ia4e47ea1fd4bc557a193b84e199dd9f3ddf1e6cb
Reviewed-on: https://chromium-review.googlesource.com/916007
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536712}
Reviewed-on: https://chromium-review.googlesource.com/922905
Cr-Commit-Position: refs/branch-heads/3325@{#481}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/loader/InteractiveDetectorTest.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/tools/metrics/ukm/ukm.xml

Comment 6 by kbr@chromium.org, Apr 12 2018

Blocking: 831925

Sign in to add a comment