Regression: power.CheckStatus TastVMTest failing on betty-release |
||||
Issue descriptionIt started failing 2 days ago: https://luci-milo.appspot.com/buildbot/chromeos/betty-release/ Assigning to sheriffs for triage.
,
Feb 1 2018
Assigning to dan.
,
Feb 1 2018
Thanks for filing this and sending it my way! I think I broke this with https://crrev.com/c/886834, which made dump_power_status log some additional data (including string battery status) for factory tests (see issue 805275 ). I thought I'd verified that everyone who parses this would be okay with strings containing spaces, but it looks like I missed some of my own code. :-P Sorry, I'll update the test right now.
,
Feb 1 2018
Looking more closely, I think that the problem isn't the presence of spaces but rather that the battery status is empty in the VM. https://crrev.com/c/886834 should fix it, in any case.
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/d6be583ee93c7a2bdb799df32209f50b4aed69cf commit d6be583ee93c7a2bdb799df32209f50b4aed69cf Author: Daniel Erat <derat@chromium.org> Date: Fri Feb 02 15:03:09 2018 tast-tests: Make power.GetStatus handle string values. Update chromiumos/tast/power's GetStatus function to handle string values that are now printed by dump_power_status. Also add LinePowerCurrent, LinePowerType, and BatteryStatus fields to the Status struct. BUG= chromium:808085 TEST=string values are reported correctly and power.CheckStatus test passes when battery status is empty (e.g. on a VM) Change-Id: Iecf9d563721d4e90cad34837c922031aac17d3d6 Reviewed-on: https://chromium-review.googlesource.com/898222 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/d6be583ee93c7a2bdb799df32209f50b4aed69cf/src/chromiumos/tast/local/power/status.go
,
Feb 3 2018
betty-release cycled green. |
||||
►
Sign in to add a comment |
||||
Comment 1 by vpalatin@google.com
, Feb 1 2018