New issue
Advanced search Search tips

Issue 808076 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Build static analyzer in ChromeOS

Project Member Reported by cmt...@chromium.org, Feb 1 2018

Issue description

As part of the plan to get the clang-tidy static analyzer running regularly on Chrome in ChromeOS, we need to update the LLVM ebuilds to build and install clang-tidy as part of LLVM, and we need to modify the wrapper scripts to allow clang-tidy to be invoked.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9e1c26a217a9d344047ac43d90e8604a72a08238

commit 9e1c26a217a9d344047ac43d90e8604a72a08238
Author: Caroline Tice <cmtice@google.com>
Date: Tue Feb 06 03:08:26 2018

[llvm] Checkout and build clang-tidy.

This is part of the work to look into setting up regular static
analyzer builds in ChromeOS.  This CL updates the LLVM ebuild to
check out, build, and install clang-tidy as part of the LLVM
build.  It also updates the compiler wrapper scripts to
invoke clang-tidy (in addition to doing the regular compilation)
if the environment variable 'WITH_TIDY' is set to 1.

BUG= chromium:808076 
TEST=Successfully built llvm and clang-tidy.  Successfully
emerged Chrome, using WITH_TIDY=1, and got clang-tidy warnings
in the build log.

Change-Id: I03f8ee2be87ea688b825cf36a12ba4627b256709
Reviewed-on: https://chromium-review.googlesource.com/802174
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[modify] https://crrev.com/9e1c26a217a9d344047ac43d90e8604a72a08238/sys-devel/llvm/llvm-6.0_pre317203_p20180123-r1.ebuild
[modify] https://crrev.com/9e1c26a217a9d344047ac43d90e8604a72a08238/sys-devel/gcc/files/sysroot_wrapper.hardened.body
[modify] https://crrev.com/9e1c26a217a9d344047ac43d90e8604a72a08238/sys-devel/llvm/files/clang_host_wrapper.body
[modify] https://crrev.com/9e1c26a217a9d344047ac43d90e8604a72a08238/sys-devel/llvm/files/wrapper_script_common

Status: Fixed (was: Assigned)

Comment 3 by cmt...@chromium.org, May 15 2018

Status: Verified (was: Fixed)

Sign in to add a comment