New issue
Advanced search Search tips

Issue 808057 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

When printing a subframe, anchors are not at the correct locations

Project Member Reported by wangxianzhu@chromium.org, Feb 1 2018 
Open the attached test case. The subframe will be printed automatically. Save the printing into a pdf file. Open the file, click the link at the top of the first page.

Expected: navigate to the page containing "TARGET"
Actual: navigate to the last page which is far from "TARGET".
window-print-subframe.html
573 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11b92d75fea81c74ce5c9d3e71a5088bd1a4ff20

commit 11b92d75fea81c74ce5c9d3e71a5088bd1a4ff20
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Feb 01 17:52:59 2018

[PE] Correct anchor position in printed subframe

When a subframe initiates printing, all coordinates should be in the
subframe's space, so we should not map anchors to the root frame.

Bug:  808057 

Change-Id: I8714cfaddc1bd5471da2561f69ef92994d57c559
Reviewed-on: https://chromium-review.googlesource.com/894464
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533723}
[delete] https://crrev.com/bc75a0353c8c730e9693383c533b16c9b080c5a5/third_party/WebKit/ManualTests/resources/print-subframe.html
[modify] https://crrev.com/11b92d75fea81c74ce5c9d3e71a5088bd1a4ff20/third_party/WebKit/ManualTests/window-print-subframe.html
[modify] https://crrev.com/11b92d75fea81c74ce5c9d3e71a5088bd1a4ff20/third_party/WebKit/Source/core/page/PrintContext.cpp

Comment 2 by wangxianzhu@chromium.org, Feb 1 2018

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2b7c8c0e1a859c32591954aaebd869cbeb47e2b

commit c2b7c8c0e1a859c32591954aaebd869cbeb47e2b
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue May 01 18:59:19 2018

Fuchsia: Minor comment cleanup pass, scrub references to "bootfs".

The revised comments more accurately reflect the current runner
behavior.

Bug:  808057 
Change-Id: I4b193241a26034d608f3e1281eea7f4ce21dd510
Reviewed-on: https://chromium-review.googlesource.com/1037780
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555130}
[modify] https://crrev.com/c2b7c8c0e1a859c32591954aaebd869cbeb47e2b/build/fuchsia/boot_data.py
[modify] https://crrev.com/c2b7c8c0e1a859c32591954aaebd869cbeb47e2b/build/fuchsia/exe_runner.py
[modify] https://crrev.com/c2b7c8c0e1a859c32591954aaebd869cbeb47e2b/build/fuchsia/test_runner.py

Comment 4 by kmarshall@chromium.org, May 1 2018 

Oops, bug typo, sorry wangxianzhu@
►

Sign in to add a comment