DocumentLifecycle.cpp has a fallthrough that looks unintentional |
|||||
Issue descriptionhttps://codereview.chromium.org/2795263002/diff/140001/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp added a case to a switch that doesn't end in break or a "falling through" comment. I think the break is probably missing and unintentional. The only case where it makes a difference is for next_state == kInPrePait.
,
Feb 1 2018
Definitely not intended, thanks for catching! I'll put up a CL to fix it and add a test if I can.
,
Feb 1 2018
,
Feb 2 2018
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d205c1a266c494be54f368a0d05317ce159ab587 commit d205c1a266c494be54f368a0d05317ce159ab587 Author: Stephen McGruer <smcgruer@chromium.org> Date: Fri Feb 02 21:18:50 2018 Fix missing 'break' in DocumentLifeCycle::CanAdvanceTo No test is added because this is a DHCECK_IS_ON only method. Bug: 808047 Change-Id: I615a07aec4223dd4c029f6e59dc864ffc7a0f739 Reviewed-on: https://chromium-review.googlesource.com/897053 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#534154} [modify] https://crrev.com/d205c1a266c494be54f368a0d05317ce159ab587/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
,
Feb 2 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Feb 1 2018