Issue metadata
Sign in to add a comment
|
SpeculativePreconnect Field Trial performance effects |
||||||||||||||||||||
Issue descriptionThe SpeculativePreconnect Field Trial was re-enabled in https://crrev.com/c/893459 Last time this trial caused bunch of regressions ( bug 784206 ) and improvements ( bug 787171 which shows regressions after the revert). I'm tracking how it's going this time.
,
Feb 1 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16f37006840000
,
Feb 2 2018
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/16f37006840000 Enable SpeculativePreconnect Field Trial Testing By alexilin@chromium.org ยท Wed Jan 31 09:21:06 2018 chromium @ 8442e044284223377ccd75e4f1b519c5656d4d8d Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Feb 2 2018
Issue 808090 has been merged into this issue.
,
Feb 5 2018
,
Feb 5 2018
Issue 808654 has been merged into this issue.
,
Feb 5 2018
,
Feb 5 2018
Issue 808655 has been merged into this issue.
,
Feb 5 2018
Issue 808658 has been merged into this issue.
,
Feb 5 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11b3d361840000
,
Feb 5 2018
๐ Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/11b3d361840000
,
Feb 6 2018
Issue 808669 has been merged into this issue.
,
Feb 6 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14b46de1840000
,
Feb 6 2018
๐ Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/14b46de1840000
,
Feb 6 2018
Issue 808659 has been merged into this issue.
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48e8746b747754f10a3494523b07f0a492ec659d commit 48e8746b747754f10a3494523b07f0a492ec659d Author: Alexandr Ilin <alexilin@chromium.org> Date: Wed Mar 07 16:19:24 2018 predictors: Allow port in urls. This CL enables predictions for URLs that have non-standard port. This is done because some performance tests that use URLs with a custom port number show regression when the predictor is enabled. Now we're trying to confirm that this is the case. This restriction was overly cautious to begin with to make sure we don't put garbage in the database. In the future we can prohibit such URLs to be written in the database but allow preconnecting to them. Bug: 808036 Change-Id: I2a41795cb584db2ed164fc6b62c31a90d5ecb483 Reviewed-on: https://chromium-review.googlesource.com/939381 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541452} [modify] https://crrev.com/48e8746b747754f10a3494523b07f0a492ec659d/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc [modify] https://crrev.com/48e8746b747754f10a3494523b07f0a492ec659d/chrome/browser/predictors/loading_data_collector.cc [modify] https://crrev.com/48e8746b747754f10a3494523b07f0a492ec659d/chrome/browser/predictors/loading_data_collector_unittest.cc
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6e03254a007461585b9b484e620893630f127a8 commit b6e03254a007461585b9b484e620893630f127a8 Author: Alexandr Ilin <alexilin@chromium.org> Date: Thu Mar 15 16:49:47 2018 predictors: Skip dns preresolution if a proxy is configured The PreconnectManager issues preconnect requests only after it preresolves a host name. If a fixed proxy configuration is in place, there is no need to make a DNS request. Bug: 808036 Change-Id: I15f6baf6405386fd6bd8154b2691c5b858c6e04b Reviewed-on: https://chromium-review.googlesource.com/958913 Reviewed-by: Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543402} [modify] https://crrev.com/b6e03254a007461585b9b484e620893630f127a8/chrome/browser/predictors/preconnect_manager.cc [modify] https://crrev.com/b6e03254a007461585b9b484e620893630f127a8/chrome/browser/predictors/preconnect_manager.h [modify] https://crrev.com/b6e03254a007461585b9b484e620893630f127a8/chrome/browser/predictors/preconnect_manager_unittest.cc
,
Mar 16 2018
,
Mar 19 2018
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b43af5ce575eb6c9b964c7fc58068a22c3420609 commit b43af5ce575eb6c9b964c7fc58068a22c3420609 Author: Alexandr Ilin <alexilin@chromium.org> Date: Thu Mar 29 20:43:10 2018 predictors: Delay predictors database write to disk The predictors database is cached in memory and can be flushed on disk only periodically. This CL adds a delay before updating the predictors database on disk. Bug: 808036 Change-Id: I29a1376c131fa33cd946ffceb7e0480c3d38093b Reviewed-on: https://chromium-review.googlesource.com/980876 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#546940} [modify] https://crrev.com/b43af5ce575eb6c9b964c7fc58068a22c3420609/chrome/browser/predictors/glowplug_key_value_data.h [modify] https://crrev.com/b43af5ce575eb6c9b964c7fc58068a22c3420609/chrome/browser/predictors/loading_predictor_config.cc [modify] https://crrev.com/b43af5ce575eb6c9b964c7fc58068a22c3420609/chrome/browser/predictors/loading_predictor_config.h [modify] https://crrev.com/b43af5ce575eb6c9b964c7fc58068a22c3420609/chrome/browser/predictors/loading_test_util.cc [modify] https://crrev.com/b43af5ce575eb6c9b964c7fc58068a22c3420609/chrome/browser/predictors/resource_prefetch_predictor.cc
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2aa00c589eaca198921047b055aefd88b22106c3 commit 2aa00c589eaca198921047b055aefd88b22106c3 Author: Alexandr Ilin <alexilin@chromium.org> Date: Thu Apr 26 08:39:43 2018 Disable SpeculativePreconnectValidation field trial This CL temporarily disables the SpeculativePreconnectValidation field trial in order to assess its impact on the perf dashboard. This feature is planned to be turned on by default after the performance evaluation. Bug: 808036 Change-Id: I69de5a26eba86b8e4cad11c4cf534c3d13e73894 Reviewed-on: https://chromium-review.googlesource.com/1028052 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553955} [modify] https://crrev.com/2aa00c589eaca198921047b055aefd88b22106c3/testing/variations/fieldtrial_testing_config.json
,
Jun 7 2018
The field trial was disabled so I' marking this as obsolete. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 1 2018