Clarify CBOR canonicalization order used in CBORWriter |
|
Issue descriptionengedy@ has suggested that we should clarify where the implemented "Canonical CBOR" map order stands in relationship to: - https://tools.ietf.org/html/rfc7049 section 3.9, - ^^ errata 4409, - CTAP 2.0 canonicalization order, and - https://github.com/cbor-wg/CBORbis/pull/9
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d1629e73736f131582452f6d310dbd969972a79 commit 6d1629e73736f131582452f6d310dbd969972a79 Author: Kouhei Ueno <kouhei@chromium.org> Date: Thu Feb 01 17:28:03 2018 CBORWriter: Add support for byte string keys. This CL: - clarifies that the map keys are sorted according to https://tools.ietf.org/html/rfc7049 section 3.9 (with errata 4409), and - add support for "byte string" keys in map. We plan to use this to encode signed exchange "Canonical CBOR". Bug: 803774, 808022 Change-Id: I336a703efe6a3910f069034086b2c84e6a81a075 Reviewed-on: https://chromium-review.googlesource.com/895227 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533714} [modify] https://crrev.com/6d1629e73736f131582452f6d310dbd969972a79/components/cbor/cbor_reader_unittest.cc [modify] https://crrev.com/6d1629e73736f131582452f6d310dbd969972a79/components/cbor/cbor_values.h [modify] https://crrev.com/6d1629e73736f131582452f6d310dbd969972a79/components/cbor/cbor_writer_unittest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by kouhei@chromium.org
, Feb 1 2018Owner: jyasskin@chromium.org
Status: Assigned (was: Unconfirmed)