New issue
Advanced search Search tips

Issue 808012 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug


Participants' hotlists:
Hotlist-OffHeapWasm


Sign in to add a comment

Null-dereference READ in v8::internal::wasm::NativeModuleSerializer::MeasureCode

Project Member Reported by ClusterFuzz, Feb 1 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4712841643556864

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  v8::internal::wasm::NativeModuleSerializer::MeasureCode
  v8::internal::wasm::NativeModuleSerializer::Measure
  v8::internal::wasm::SerializeNativeModule
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=50770:50771

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4712841643556864

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 1 2018

Components: Blink>JavaScript>WebAssembly
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Feb 1 2018

Labels: Test-Predator-Auto-Owner
Owner: mstarzinger@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/e11c57fe9e7b7db6a9bd707642ea1cdfa92102f5 ([wasm] Remove {NativeModule::lazy_builtin} field.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Labels: -Pri-1 Pri-2
Yep, this is mine, requires --wasm-lazy-compilation, hence lowering priority.
Status: Started (was: Assigned)
Fix is in flight: https://chromium-review.googlesource.com/c/v8/v8/+/899122
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/61391f366b704d8d50c2e4ce9882e31518518fc3

commit 61391f366b704d8d50c2e4ce9882e31518518fc3
Author: Michael Starzinger <mstarzinger@chromium.org>
Date: Mon Feb 05 22:01:56 2018

[wasm] Ensure WasmCode always has protected instructions.

R=clemensh@chromium.org
TEST=mjsunit/regress/wasm/regress-808012
BUG= chromium:808012 

Change-Id: Ia1e4527c6c845ffd01ecf5c7fa13b8b484d6ef6e
Reviewed-on: https://chromium-review.googlesource.com/899122
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51103}
[modify] https://crrev.com/61391f366b704d8d50c2e4ce9882e31518518fc3/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/61391f366b704d8d50c2e4ce9882e31518518fc3/src/wasm/wasm-code-manager.h
[add] https://crrev.com/61391f366b704d8d50c2e4ce9882e31518518fc3/test/mjsunit/regress/wasm/regress-808012.js

Status: Fixed (was: Started)
Project Member

Comment 7 by ClusterFuzz, Feb 6 2018

ClusterFuzz has detected this issue as fixed in range 51102:51103.

Detailed report: https://clusterfuzz.com/testcase?key=4712841643556864

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  v8::internal::wasm::NativeModuleSerializer::MeasureCode
  v8::internal::wasm::NativeModuleSerializer::Measure
  v8::internal::wasm::SerializeNativeModule
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=50770:50771
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=51102:51103

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4712841643556864

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Feb 6 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4712841643556864 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment