New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 808008 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Bisect improvements from v8 r50967

Project Member Reported by gab@chromium.org, Feb 1 2018

Issue description

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/12ce0e76840000
๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14a343a6840000
๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/1482ecd6840000
Cc: dalecur...@chromium.org crouleau@chromium.org
Owner: dalecur...@chromium.org
Status: Assigned (was: Started)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1482ecd6840000

Make some media_perftests TEST_P, remove/replace useless cases.
By dalecurtis@chromium.org ยท Wed Jan 31 01:38:33 2018
chromium @ e517a1c2836aa4e971db9e28259582b0cd58a49a

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 5 by gab@chromium.org, Feb 1 2018

Components: Infra>Client>Perf
Owner: gab@chromium.org
Sorry I'm just digging graphs, this isn't intended to auto-assign bugs... I don't know how to prevent new pinpoint tool from doing that..

(also this looks like a terrible pinpoint... doesn't pinpoint support pinpointing improvements? that's what I'm trying to achieve)

Comment 6 by gab@chromium.org, Feb 1 2018

Cc: -dalecur...@chromium.org -crouleau@chromium.org
Cc: kinuko@chromium.org steve...@chromium.org aleventhal@chromium.org dtseng@chromium.org dmazz...@chromium.org
Owner: aleventhal@chromium.org
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12ce0e76840000

Layout tables should still be exposed as tables.
By aleventhal@chromium.org ยท Wed Jan 31 01:08:25 2018
chromium @ 7686e185bd779c1fdd8ea7e76bb84f88b941ce24

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 8 by dtu@chromium.org, Feb 1 2018

Sorry, there isn't yet an option to skip auto-assigning bugs, since we've been focused on the launch of the perf sheriff use cases. I've filed a bug: go/catabug/4225

Pinpoint does support pinpointing improvements. Were you expecting to see one in one of the above jobs?

Comment 9 by dtu@chromium.org, Feb 1 2018

Cc: -dtseng@chromium.org -aleventhal@chromium.org -kinuko@chromium.org -dmazz...@chromium.org -steve...@chromium.org dtu@chromium.org
Owner: gab@chromium.org

Comment 10 by gab@chromium.org, Feb 2 2018

@dtu: yes. I was looking at graphs impacted in my CL's range @ https://chromeperf.appspot.com/group_report?rev=533152

And trying to pinpoint whether my CL was specifically to thank for the improvement. This is very hard to do at the moment it seems...
๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14cb23e1840000

Comment 12 by gab@chromium.org, Feb 13 2018

Status: Archived (was: Assigned)
This was inconclusive, looks like pinpoint isn't great at identifying improvements are at least I couldn't figure out how to make it work :(

Sign in to add a comment