New issue
Advanced search Search tips

Issue 807988 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Mar 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Fix toolbar background color during side swipe

Project Member Reported by gambard@chromium.org, Feb 1 2018 
The background color of the toolbar should be something TBD when side swiping to change tab.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f1b99ce048322ad2215607dd00ccb946424b334

commit 6f1b99ce048322ad2215607dd00ccb946424b334
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Mar 09 15:49:46 2018

Change toolbar background color during side swipe

During side swipe, the snapshot of the toolbar cannot have the blur
effect. This CL adds a solid grey background on the toolbar during the
side swipe.

Bug:  807988 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6301068a453e70cc1da005858657dd0fdd2f8ea1
Reviewed-on: https://chromium-review.googlesource.com/955422
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542122}
[modify] https://crrev.com/6f1b99ce048322ad2215607dd00ccb946424b334/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm
[modify] https://crrev.com/6f1b99ce048322ad2215607dd00ccb946424b334/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view.h
[modify] https://crrev.com/6f1b99ce048322ad2215607dd00ccb946424b334/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/6f1b99ce048322ad2215607dd00ccb946424b334/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h
[modify] https://crrev.com/6f1b99ce048322ad2215607dd00ccb946424b334/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/6f1b99ce048322ad2215607dd00ccb946424b334/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm
[modify] https://crrev.com/6f1b99ce048322ad2215607dd00ccb946424b334/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.h
[modify] https://crrev.com/6f1b99ce048322ad2215607dd00ccb946424b334/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.mm

Comment 2 by gambard@chromium.org, Mar 9 2018

Labels: -Q2 Q1
NextAction: 2018-03-14
Status: Fixed (was: Assigned)

Comment 3 by monor...@bugs.chromium.org, Mar 14 2018 

The NextAction date has arrived: 2018-03-14

Comment 4 by cmasso@google.com, Mar 14 2018

NextAction: ----
►

Sign in to add a comment