New issue
Advanced search Search tips

Issue 807987 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 417782



Sign in to add a comment

[root layer scrolls] RTL page loads at scroll offset

Project Member Reported by bokan@chromium.org, Feb 1 2018

Issue description

What steps will reproduce the problem?
1. Launch chrome with --root-layer-scrolls
2. Visit https://bokand.github.io/bugs/rtl-rls-scroll.html


What is the expected result?
The page should load fully scrolled to the right

What happens instead of that?
The page is loaded with about a screen width (on my Nexus 6) of scroll offset from the right edge, though not fully scrolled left either.

Curiously, I don't see this behavior on desktop. 
 

Comment 1 by bokan@chromium.org, Feb 2 2018

Owner: ----
Status: Available (was: Assigned)
There's more urgent and relevant-to-me bugs that I'll start on.
Cc: -skobes@chromium.org
Owner: skobes@chromium.org
Status: Started (was: Available)
Blocking: 417782
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6846eee179c8e25fcd4a16f56ce857ab952026cc

commit 6846eee179c8e25fcd4a16f56ce857ab952026cc
Author: Steve Kobes <skobes@chromium.org>
Date: Sat Feb 10 03:08:15 2018

RLS: Fix scroll offsets on RTL pages with horizontal overflow.

Clamping the root PLSA should be done after the FrameView is resized,
because the size of the FrameView determines the scroll bounds of the
layout viewport (through LayoutView::OverflowClipRect).

This fixes two symptoms:

- incorrect initial scroll offset on Android, where the FrameView's
  width at construction time is the 980px layout fallback width

- failure to preserve scroll offset during window resize on desktop,
  since the clamping was based on the previous size

Bug:  807987 
Change-Id: I6a6d2a25879fe8e89d3e1d6b958b3e6754c0108e
Reviewed-on: https://chromium-review.googlesource.com/911946
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535946}
[modify] https://crrev.com/6846eee179c8e25fcd4a16f56ce857ab952026cc/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/6846eee179c8e25fcd4a16f56ce857ab952026cc/third_party/WebKit/Source/core/layout/LayoutView.cpp

Comment 5 by skobes@chromium.org, Feb 12 2018

Status: Fixed (was: Started)

Sign in to add a comment