New issue
Advanced search Search tips

Issue 807985 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in CPDF_ContentParser::~CPDF_ContentParser

Project Member Reported by ClusterFuzz, Feb 1 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5464984369496064

Fuzzer: attekett_surku_fuzzer
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Heap-use-after-free READ 1
Crash Address: 0x7b0400004cc0
Crash State:
  CPDF_ContentParser::~CPDF_ContentParser
  CPDF_Form::ParseContent
  CPDF_Annot::GetAPForm
  
Sanitizer: thread (TSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=533126:533132

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5464984369496064

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 1 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Feb 1 2018

Cc: dsinclair@chromium.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Cleanup duplicate RunScript code by dsinclair@chromium.org - https://pdfium.googlesource.com/pdfium/+/8cdea72a82aae5e07aa92e9886dbbe635eb8b7cc

Cleanup some param passing code by dsinclair@chromium.org - https://pdfium.googlesource.com/pdfium/+/1d82ba42da7afc4ee0e32b41da36c9f20fd3d070

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 1 2018

Labels: M-65
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 1 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 1 2018

Labels: Pri-1
Labels: Needs-Bisect
Owner: hnakashima@chromium.org
Status: Assigned (was: Untriaged)
The stack doesn't seem to make a lot of sense that ClusterFuzz is providing. I don't think this is related to my CLs.

hnakashima@ can you take a look?

Adding Needs-Bisect in the hope we can get a better regression range.
Cc: thestig@chromium.org
Isn't TSAN reporting UAF also weird?
This is ProbeForLowSeverityLifetimeIssue, but the report doesn't make it obvious.
Project Member

Comment 9 by sheriffbot@chromium.org, Feb 2 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Owner: tsepez@chromium.org
Tom, bisect points at https://pdfium-review.googlesource.com/c/pdfium/+/24671 as culprit. Can you take a look?
Labels: -Security_Severity-High Security_Severity-Low
Owner: hnakashima@chromium.org
Yes, but that's just the CL that turns on detection.  The dangling pointer so flagged is a pre-existing issue.

ProbeForLowSeverityLifetimeIssue is a low severity issue.
Labels: -Pri-1 Pri-2
Labels: -ReleaseBlock-Stable
Since this is low severity, it doesn't block the release.
Project Member

Comment 14 by ClusterFuzz, Feb 11 2018

ClusterFuzz has detected this issue as fixed in range 535983:535984.

Detailed report: https://clusterfuzz.com/testcase?key=5464984369496064

Fuzzer: attekett_surku_fuzzer
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Heap-use-after-free READ 1
Crash Address: 0x7b0400004cc0
Crash State:
  CPDF_ContentParser::~CPDF_ContentParser
  CPDF_Form::ParseContent
  CPDF_Annot::GetAPForm
  
Sanitizer: thread (TSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=533126:533132
Fixed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=535983:535984

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5464984369496064

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 15 by ClusterFuzz, Feb 11 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5464984369496064 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 16 by sheriffbot@chromium.org, Feb 11 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -reward-topanel reward-0
The Chrome VRP panel took a look at this and decided that it was very unlikely to be exploitable, so declined to reward.
Project Member

Comment 18 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Beta Security_Impact-Stable
Project Member

Comment 19 by sheriffbot@chromium.org, May 20 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment