Regression: Unnecessary 'Export' option is seen enabled in chrome://settings/passwords page
Reported by
khushal....@etouch.net,
Feb 1 2018
|
||||
Issue descriptionChrome Version: 64.0.3282.140 (Official Build) (cohort: 64_119_win) Revision a06bc1d5e8e285c70078802de990c1719ccc75e8-refs/branch-heads/3282@{#631} (32/64-bit) OS: Windows (7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.3), Linux (14.04 LTS). Precondition: Enabled Password export and Password import flags from the chrome://flags What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://settings/passwords page. (2) Click on 'More actions' and observe 'Export' option. Actual: Unnecessary 'Export' option is seen enabled and blank password is exporting after clicking on it. Expected: 'Export' option should be in disabled state if there is no password to export. This is a regression issue, broken in 'M64' and providing the bisect using per-revision bisect Good Build: 64.0.3268.0(Revision: 516148) Bad Build: 64.0.3269.0(Revision: 516552) You are probably looking for a change made after 516248(known good), but no later than 516249(first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/1588705ebeb353d9be5a29e169ea724742ceebdc..a2a5b471a29fdd1f1beafb8d580539f18365364d Suspect: https://chromium.googlesource.com/chromium/src/+/a2a5b471a29fdd1f1beafb8d580539f18365364d Note: Issue is also seen on M65 Dev(#65.0.3325.31) and M66 Canary(#66.0.3336.0)
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d57ac0affdfc1080acc0de78384260798681b92c commit d57ac0affdfc1080acc0de78384260798681b92c Author: Christos Froussios <cfroussios@chromium.org> Date: Tue Feb 06 18:32:11 2018 [Password Manager] Show export menu item only for a non-empty password list Exporting an empty password list has no value for the user. Additionally, exporting while the password list is still loading is undefined behaviour. For these reasons, we only show the Export Passwords menu item only once the password list has been read and is non-empty. Bug: 789561 , 805534 , 807975 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ief82b4b46a231402dbaa7251e514c4078f7be31a Reviewed-on: https://chromium-review.googlesource.com/897486 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#534728} [modify] https://crrev.com/d57ac0affdfc1080acc0de78384260798681b92c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
,
Feb 7 2018
,
Feb 7 2018
Update : Retested above issue on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS) OS using latest Canary #66.0.3342.0 and issue is fixed. Kindly review the attached screen-cast.
,
Mar 5 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by khushal....@etouch.net
, Feb 1 2018