New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 807972 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Synced history data is not shown in omnibox suggestions list

Project Member Reported by rakurati@chromium.org, Feb 1 2018

Issue description

App Version: 65.0.3325.36 Beta
iOS Version: 11.2.2 and 10.3.3
Device: iPhone and iPad

Prerequisite: Consider two devices (A & B) and login with same account.

Steps to reproduce:
1. Fresh install and launch chrome in both devices
2. In device A, tap on any article in content suggestion
3. Go to history in device B and wait for some time until the history get synced.
4. Go to NTP in B and start typing in synced URL or web page title.

Observed results:
Notice that omnibox suggestions will not display the synced URL.

Note 1: Load any webpage from omnibox in device A and let it sync to device B. On typing relevant text in device B will display history suggestions.
Note 2: Load any webpage from omnibox in device A and bookmark the page. Once the bookmark is synced, on typing relevant text in device B will display bookmark suggestion.

Expected results:
Suggestion should be displayed

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): Yes on M64
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M65

Link to video/image:

https://drive.google.com/file/d/18e1Q9PlfL-uoSB9oQPu-qrfKi8V4KRyT/view?usp=sharing

 

Comment 1 by treib@chromium.org, Feb 1 2018

Cc: treib@chromium.org mastiz@chromium.org
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
I think this is working as designed (though maybe not quite as intended), has always been the case, and is not iOS-specific.

History Sync uploads history, but we don't actually download it on all devices. The chrome://history page fetches synced history on demand, but other places in Chrome (like the Omnibox) don't have access to it.

+mastiz who's been thinking of making History Sync more robust.

Comment 2 by treib@chromium.org, Feb 19 2018

Labels: -Type-Bug Sync-Triaged Type-Feature
Status: Available (was: Untriaged)
Owner: jkrcal@chromium.org
Status: Assigned (was: Available)
Thanks for filing the bug!

We currently sync this information if an address is *typed* in the omnibox. I tried this out, and indeed the suggestion shows up in A's omnibox, but not in B's, which seems undesirable.

We could narrow down the scope of this bug and fix article suggestions specifically, that is, sync AUTO_BOOKMARK page transition types in TypedUrlSyncBridge. Handing over to jkrcal@ for further considerations.

That's interesting! A few questions, Mikel:

 - Do we use full history locally for omnibox suggestions but we only sync typed URLs?
 - Does a most likely ntp tile also trigger an AUTO_BOOKMARK page transition?
 - Do we have some statistics on percentage of AUTO_BOOKMARK transitions versus TYPED transition? (to understand the potential increase in sync traffic)

Personally, this is on the edge between WontFix and actually doing something about the issue. I do not think we can fix a lot with the current design of typed URL but AUTO_BOOKMARK seems acceptable.
1. I don't know the details of how the omnibox is populated (mpearson@ would know), but empirically it does display AUTO_BOOKMARKs.

2. NTP surfaces AUTO_BOOKMARK, but there's a boolean (consider_for_ntp_most_visited) that allows callers to filter it out, which we do for article suggestions.

3. cdcs@ once did detailed analysis of this, which I don't recall now, but I'd estimate AUTO_BOOKMARK being in the same order of magnitude as TYPED.

Sign in to add a comment