CL incorrectly flagged as culprit, no way to say it's not..? |
||
Issue description@ https://chromium-review.googlesource.com/c/chromium/src/+/895362#message-d2f73f35d00ec0e554c391894fe951d33499004c my CL was flagged as culprit and I highly doubt it was. There's no button to tell FindIt that this was wrong (and now I'm leery that I missed an automated revert...). If these are just informative FYIs with low certainty at least the message should make that clear.
,
Feb 1 2018
Findit thought r533227 was the culprit for TwoPhaseUploaderTest.PhaseTwoConnectionClosed based on try job. But it's highly likely that TwoPhaseUploaderTest.PhaseTwoConnectionClosed was a flake just as other failed tests in unit_tests. r533226 should not be culprit for this test. In try job the test passed all 20 times on r533226 and failed all 20 times on r533227. The try job WAI.
,
Apr 20 2018
Even though the try job WAI, it is still a false positive from the user perspective. We need to fix this. And in particular, we need to make it easy for users to tell us that there is a false positive. |
||
►
Sign in to add a comment |
||
Comment 1 by st...@chromium.org
, Feb 1 2018Owner: chanli@chromium.org
Status: Assigned (was: Unconfirmed)